PMD Results

The following document contains the results of PMD 5.0.5.

Files

org/andromda/core/AndroMDA.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 35
Private field 'engine' could be made final; it is only initialized in the declaration or constructor. 35
Parameter 'lastModifiedCheck' is not assigned and could be declared final 166
Avoid if (x != y) ..; else ..; 169213
Avoid if (x != y) ..; else ..; 176201
A catch statement should never catch throwable since it includes errors. 182
Avoid throwing raw exception types. 194

org/andromda/core/AndroMDAServer.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 22
Private field 'server' could be made final; it is only initialized in the declaration or constructor. 22
A catch statement should never catch throwable since it includes errors. 77

org/andromda/core/cartridge/Cartridge.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 1827
Local variable 'resource' could be declared final 63
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 78
The String literal "template" appears 4 times in this file; the first occurrence is on line 98 98
Avoid if (x != y) ..; else ..; 103130
Local variable 'templateModelElement' could be declared final 105
Avoid really long methods. 139261
Avoid if (x != y) ..; else ..; 188198
Avoid instantiating new objects inside loops 197
Local variable 'metafacade' could be declared final 213
Avoid instantiating new objects inside loops 215
A catch statement should never catch throwable since it includes errors. 255
Local variable 'entry' could be declared final 294
Avoid really long methods. 359484
Local variable 'postProcessor' could be declared final 430
Local variable 'lResult' could be declared final 436
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 446
A catch statement should never catch throwable since it includes errors. 472
These nested if statements could be combined 513527
Useless parentheses. 603
These nested if statements could be combined 607613
A catch statement should never catch throwable since it includes errors. 618
Found non-transient, non-static member. Please mark as transient or provide accessors. 633
Parameter 'templateContext' is not assigned and could be declared final 666
Found non-transient, non-static member. Please mark as transient or provide accessors. 675
Found non-transient, non-static member. Please mark as transient or provide accessors. 680
Found non-transient, non-static member. Please mark as transient or provide accessors. 685
Found non-transient, non-static member. Please mark as transient or provide accessors. 711
Avoid using redundant field initializer for 'conditionsEvaluated' 711
Avoid if (x != y) ..; else ..; 773
StringBuffer constructor is initialized with size 16, but has at least 82 characters appended. 818
Local variable 'builder' could be declared final 818
Avoid appending characters as strings in StringBuffer.append. 824

org/andromda/core/cartridge/CartridgeException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39
Parameter 'parent' is not assigned and could be declared final 49

org/andromda/core/cartridge/Resource.java

Violation Line
Avoid reassigning parameters such as 'outputPattern' 82
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 104
Avoid using redundant field initializer for 'overwrite' 120
Local variable 'builder' could be declared final 259
StringBuffer constructor is initialized with size 16, but has at least 95 characters appended. 259
Avoid appending characters as strings in StringBuffer.append. 267

org/andromda/core/cartridge/template/ModelElement.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 50
Local variable 'type' could be declared final 176
Local variable 'property' could be declared final 187
Deeply nested if..then statements are hard to read 194199
A catch statement should never catch throwable since it includes errors. 203

org/andromda/core/cartridge/template/ModelElements.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 23
It is somewhat confusing to have a field name matching the declaring class name 23
Avoid reassigning parameters such as 'variable' 41
Local variable 'modelElement' could be declared final 67

org/andromda/core/cartridge/template/Template.java

Violation Line
It is a good practice to call super() in a constructor 2427
Avoid using redundant field initializer for 'generateEmptyFiles' 33
Avoid reassigning parameters such as 'outputPattern' 73
Avoid using redundant field initializer for 'outputToSingleFile' 135
Local variable 'builder' could be declared final 194
StringBuffer constructor is initialized with size 16, but has at least 92 characters appended. 194
Avoid appending characters as strings in StringBuffer.append. 200
Found non-transient, non-static member. Please mark as transient or provide accessors. 207
Avoid using redundant field initializer for 'supportedModelElements' 207

org/andromda/core/cartridge/template/TemplateException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 17
Parameter 'message' is not assigned and could be declared final 27
Parameter 'message' is not assigned and could be declared final 39
Parameter 'parent' is not assigned and could be declared final 40

org/andromda/core/cartridge/template/Type.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 46
Found non-transient, non-static member. Please mark as transient or provide accessors. 85
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 85
Private field 'variable' could be made final; it is only initialized in the declaration or constructor. 86
Found non-transient, non-static member. Please mark as transient or provide accessors. 86
Private field 'value' could be made final; it is only initialized in the declaration or constructor. 87
Found non-transient, non-static member. Please mark as transient or provide accessors. 87

org/andromda/core/common/AndroMDALogger.java

Violation Line
Class contains more than one logger. 21223
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 22223
The Logger variable declaration does not contain the static and final modifiers 27
Local variable 'defaultConfiguration' could be declared final 35
Local variable 'stream' could be declared final 43
A catch statement should never catch throwable since it includes errors. 49
Avoid throwing raw exception types. 63
Avoid using redundant field initializer for 'loggingConfigurationUri' 71
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 94
System.out.print is used 97
Avoid if (x != y) ..; else ..; 113120
Parameter 'object' is not assigned and could be declared final 195
Parameter 'object' is not assigned and could be declared final 203
Parameter 'object' is not assigned and could be declared final 211
Parameter 'object' is not assigned and could be declared final 219

org/andromda/core/common/BasePlugin.java

Violation Line
Abstract classes should be named AbstractXXX 22283
Found non-transient, non-static member. Please mark as transient or provide accessors. 29
Found non-transient, non-static member. Please mark as transient or provide accessors. 34
A method/constructor shouldnt explicitly throw java.lang.Exception 40
Avoid if (x != y) ..; else ..; 50
Found non-transient, non-static member. Please mark as transient or provide accessors. 65
Found non-transient, non-static member. Please mark as transient or provide accessors. 117
Found non-transient, non-static member. Please mark as transient or provide accessors. 132
Avoid using redundant field initializer for 'templateEngine' 132
Avoid reassigning parameters such as 'templateContext' 174
Local variable 'templateObject' could be declared final 196
Avoid using redundant field initializer for 'contents' 230
Found non-transient, non-static member. Please mark as transient or provide accessors. 230
Deeply nested if..then statements are hard to read 247250

org/andromda/core/common/BuildInformation.java

Violation Line
Field INSTANCE has the same name as a method 18
Found non-transient, non-static member. Please mark as transient or provide accessors. 41
Found non-transient, non-static member. Please mark as transient or provide accessors. 46
Found non-transient, non-static member. Please mark as transient or provide accessors. 51
Found non-transient, non-static member. Please mark as transient or provide accessors. 56
Found non-transient, non-static member. Please mark as transient or provide accessors. 61
Local variable 'stream' could be declared final 80
A catch statement should never catch throwable since it includes errors. 90
New exception is thrown in catch block, original stack trace may be lost 93

org/andromda/core/common/ClassUtils.java

Violation Line
Comment is too large: Line too long 16
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 25394
A catch statement should never catch throwable since it includes errors. 38
Avoid if (x != y) ..; else ..; 54
A catch statement should never catch throwable since it includes errors. 56
Avoid reassigning parameters such as 'className' 69
Avoid reassigning parameters such as 'className' 69
A catch statement should never catch throwable since it includes errors. 98
Local variable 'field' could be declared final 163
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 167
Local variable 'fieldsNum' could be declared final 193
Avoid if (x != y) ..; else ..; 204214
Local variable 'interfaces' could be declared final 269
Local variable 'directoryUri' could be declared final 311
Avoid empty catch blocks 335338

org/andromda/core/common/ClassUtilsException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/common/ComponentContainer.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 50
Avoid using redundant field initializer for 'instance' 55
Field instance has the same name as a method 55
Singleton is not thread safe 6467
Parameter 'implementation' is not assigned and could be declared final 95
The String literal "type" appears 5 times in this file; the first occurrence is on line 147 147
A catch statement should never catch throwable since it includes errors. 160
The String literal "key" appears 4 times in this file; the first occurrence is on line 190 190
A catch statement should never catch throwable since it includes errors. 262
A catch statement should never catch throwable since it includes errors. 489
A catch statement should never catch throwable since it includes errors. 528
A catch statement should never catch throwable since it includes errors. 548
A catch statement should never catch throwable since it includes errors. 570
Assigning an Object to null is a code smell. Consider refactoring. 582

org/andromda/core/common/ComponentContainerException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/common/Converter.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 17142
Avoid reassigning parameters such as 'object' 36
Avoid reassigning parameters such as 'object' 36
Avoid reassigning parameters such as 'object' 36
Avoid reassigning parameters such as 'object' 36
Avoid reassigning parameters such as 'expectedType' 37
Avoid empty catch blocks 6669
New exception is thrown in catch block, original stack trace may be lost 8283
A catch statement should never catch throwable since it includes errors. 88
Local variable 'trace' could be declared final 95
Prefer StringBuffer over += for concatenating strings 99
Variables that are final and static should be all capitals, 'primitiveWrappers' is not all capitals. 110
Do not use the short type 127

org/andromda/core/common/ExceptionRecorder.java

Violation Line
Variables that are final and static should be all capitals, 'logger' is not all capitals. 23
Use explicit scoping instead of the default package private level 28
Use explicit scoping instead of the default package private level 33
Use explicit scoping instead of the default package private level 38
Use explicit scoping instead of the default package private level 43
Variables that are final and static should be all capitals, 'exceptionDirectoryName' is not all capitals. 48
Avoid using redundant field initializer for 'exceptionDirectory' 53
When instantiating a SimpleDateFormat object, specify a Locale 54
Variables that are final and static should be all capitals, 'cvDateFormat' is not all capitals. 54
Variables that are final and static should be all capitals, 'random' is not all capitals. 55
Variables that are final and static should be all capitals, 'instance' is not all capitals. 60
Field instance has the same name as a method 60
Parameter 'throwable' is not assigned and could be declared final 89
Parameter 'errorMessage' is not assigned and could be declared final 105
Parameter 'throwable' is not assigned and could be declared final 106
Parameter 'message' is not assigned and could be declared final 128
Parameter 'throwable' is not assigned and could be declared final 129
Avoid reassigning parameters such as 'prefix' 130
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 158
A catch statement should never catch throwable since it includes errors. 175
Parameter 'prefix' is not assigned and could be declared final 194
Use block level rather than method level synchronization 194232
Avoid instantiating new objects inside loops 201
Avoid instantiating new objects inside loops 202
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 227
Avoid empty catch blocks 227230
Avoid empty catch blocks 245248
A catch statement should never catch throwable since it includes errors. 245

org/andromda/core/common/ExceptionUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 11247
Avoid reassigning parameters such as 'throwable' 220
Parameter 'stackDepth' is not assigned and could be declared final 235
Avoid throwing raw exception types. 238

org/andromda/core/common/ImportBeautifierPostProcessorImpl.java

Violation Line
Parameter 'pFile' is not assigned and could be declared final 22
Parameter 'pSource' is not assigned and could be declared final 34
A method/constructor shouldnt explicitly throw java.lang.Exception 34
Parameter 'pPreviousData' is not assigned and could be declared final 34

org/andromda/core/common/Introspector.java

Violation Line
Field instance has the same name as a method 25
Avoid using redundant field initializer for 'instance' 25
Singleton is not thread safe 3437
Variables that are final and static should be all capitals, 'logger' is not all capitals. 44
Use bitwise inversion to invert boolean values 88
A catch statement should never catch throwable since it includes errors. 104
Avoid reassigning parameters such as 'name' 144
Local variable 'names' could be declared final 154
Unnecessary final modifier in final class 181221
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 193
Avoid catching NullPointerException; consider removing the cause of the NPE. 193
A method should have only one exit point, and that should be the last statement in the method 195
A method should have only one exit point, and that should be the last statement in the method 199
A catch statement that catches an exception only to rethrow it should be avoided. 201207
A catch statement should never catch throwable since it includes errors. 208
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 214
Local variable 'dotIndex' could be declared final 238
Found non-transient, non-static member. Please mark as transient or provide accessors. 267
Avoid if (x != y) ..; else ..; 296
Found non-transient, non-static member. Please mark as transient or provide accessors. 347
Avoid if (x != y) ..; else ..; 376
Found non-transient, non-static member. Please mark as transient or provide accessors. 393
Found non-transient, non-static member. Please mark as transient or provide accessors. 398
Private field 'propertyNamePattern' could be made final; it is only initialized in the declaration or constructor. 398
Local variable 'dotIndex' could be declared final 445
Found non-transient, non-static member. Please mark as transient or provide accessors. 480
A catch statement should never catch throwable since it includes errors. 521
Local variable 'trace' could be declared final 528
Prefer StringBuffer over += for concatenating strings 532
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 536
Avoid reassigning parameters such as 'value' 559
Useless parentheses. 561
A catch statement should never catch throwable since it includes errors. 593
Assigning an Object to null is a code smell. Consider refactoring. 610
Local variable 'builder' could be declared final 619
StringBuffer constructor is initialized with size 16, but has at least 109 characters appended. 619
Avoid appending characters as strings in StringBuffer.append. 624

org/andromda/core/common/IntrospectorException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 21
Parameter 'message' is not assigned and could be declared final 33

org/andromda/core/common/Merger.java

Violation Line
Variables that are final and static should be all capitals, 'logger' is not all capitals. 30
Variables that are final and static should be all capitals, 'instance' is not all capitals. 35
Field instance has the same name as a method 35
Found non-transient, non-static member. Please mark as transient or provide accessors. 40
Avoid reassigning parameters such as 'string' 66
Avoid reassigning parameters such as 'string' 66
Deeply nested if..then statements are hard to read 8690
Avoid variables with short names like to 88
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 121
Use bitwise inversion to invert boolean values 143
Assigning an Object to null is a code smell. Consider refactoring. 170
Avoid if (x != y) ..; else ..; 170
Local variable 'mergeMappingsUriValue' could be declared final 170
Deeply nested if..then statements are hard to read 174195
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 181
Deeply nested if..then statements are hard to read 196199

org/andromda/core/common/MergerException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 18
Parameter 'message' is not assigned and could be declared final 28
Parameter 'message' is not assigned and could be declared final 40
Parameter 'parent' is not assigned and could be declared final 41

org/andromda/core/common/Paragraph.java

Violation Line
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 18
Found non-transient, non-static member. Please mark as transient or provide accessors. 18
Found non-transient, non-static member. Please mark as transient or provide accessors. 19
Private field 'maxLineWidth' could be made final; it is only initialized in the declaration or constructor. 19
Local variable 'tokenizer' could be declared final 62
Found non-transient, non-static member. Please mark as transient or provide accessors. 69

org/andromda/core/common/PathMatcher.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 12101
Avoid reassigning parameters such as 'path' 36
Avoid reassigning parameters such as 'path' 36
Avoid reassigning parameters such as 'pattern' 37
Avoid reassigning parameters such as 'pattern' 37
Avoid reassigning parameters such as 'pattern' 37
Avoid reassigning parameters such as 'pattern' 37
Local variable 'matchAll' could be declared final 62

org/andromda/core/common/Plugin.java

Violation Line
Avoid modifiers which are implied by the context 2324
A method/constructor shouldnt explicitly throw java.lang.Exception 24
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 37
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 59

org/andromda/core/common/PluginException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 18
Parameter 'message' is not assigned and could be declared final 30
Parameter 'parent' is not assigned and could be declared final 31
Parameter 'parent' is not assigned and could be declared final 41

org/andromda/core/common/PostProcessor.java

Violation Line
Avoid modifiers which are implied by the context 16
Avoid modifiers which are implied by the context 25
A method/constructor shouldnt explicitly throw java.lang.Exception 25

org/andromda/core/common/ResourceFinder.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 1441
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 36

org/andromda/core/common/ResourceFinderException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/common/ResourceUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 35871
Variables that are final and static should be all capitals, 'logger' is not all capitals. 36
Avoid if (x != y) ..; else ..; 65
Local variable 'resource' could be declared final 65
Avoid variables with short names like in 80
Avoid throwing raw exception types. 90
Avoid throwing raw exception types. 109
Avoid empty catch blocks 141144
Avoid reassigning parameters such as 'filePath' 179
Parameter 'includeSubdirectories' is not assigned and could be declared final 202
Parameter 'includeSubdirectories' is not assigned and could be declared final 251
Local variable 'file' could be declared final 254
Parameter 'includeSubdirectories' is not assigned and could be declared final 269
Assigning an Object to null is a code smell. Consider refactoring. 277
Local variable 'zipFile' could be declared final 321
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 335
A catch statement that catches an exception only to rethrow it should be avoided. 335338
A catch statement should never catch throwable since it includes errors. 340
Avoid throwing raw exception types. 342
A method should have only one exit point, and that should be the last statement in the method 409
Avoid empty catch blocks 411414
Local variable 'uriConnection' could be declared final 465
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 476
Avoid reassigning parameters such as 'path' 519
Avoid empty catch blocks 538541
The method resolveClasspathResource() has an NPath complexity of 12076 564641
Avoid reassigning parameters such as 'path' 564
Assigning an Object to null is a code smell. Consider refactoring. 636
Parameter 'absolute' is not assigned and could be declared final 693
Avoid if (x != y) ..; else ..; 702751
Avoid if (x != y) ..; else ..; 707721
Prefer StringBuffer over += for concatenating strings 715
Prefer StringBuffer over += for concatenating strings 715
Avoid if (x != y) ..; else ..; 740749
Useless parentheses. 768
Parameter 'time' is not assigned and could be declared final 796
Local variable 'file' could be declared final 801
Avoid excessively long variable names like BACK_SLASH_NORMALIZATION_PATTERN 815
Avoid excessively long variable names like FORWARD_SLASH_NORMALIZATION_PATTERN 820
Avoid if (x != y) ..; else ..; 831836

org/andromda/core/common/ResourceWriter.java

Violation Line
Field instance has the same name as a method 22
Variables that are final and static should be all capitals, 'instance' is not all capitals. 22
Avoid if (x != y) ..; else ..; 92
Avoid reassigning parameters such as 'string' 151
Avoid reassigning parameters such as 'string' 151
Found non-transient, non-static member. Please mark as transient or provide accessors. 202
Avoid using redundant field initializer for 'encoding' 202
Parameter 'encoding' is not assigned and could be declared final 210
Found non-transient, non-static member. Please mark as transient or provide accessors. 215
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 215
Local variable 'lastSlash' could be declared final 227
Avoid using redundant field initializer for 'modelFile' 239
Found non-transient, non-static member. Please mark as transient or provide accessors. 239
Found non-transient, non-static member. Please mark as transient or provide accessors. 244
Avoid using redundant field initializer for 'writtenCount' 244
Avoid using redundant field initializer for 'historyDir' 260
Found non-transient, non-static member. Please mark as transient or provide accessors. 260
Parameter 'historyDirIn' is not assigned and could be declared final 275
Parameter 'file' is not assigned and could be declared final 299
Parameter 'time' is not assigned and could be declared final 315
Local variable 'fileName' could be declared final 326
Avoid instantiating new objects inside loops 330
Local variable 'file' could be declared final 330
Deeply nested if..then statements are hard to read 334338
Deeply nested if..then statements are hard to read 339342

org/andromda/core/common/TemplateObject.java

Violation Line
Variables that are final and static should be all capitals, 'logger' is not all capitals. 22
Found non-transient, non-static member. Please mark as transient or provide accessors. 48
A catch statement should never catch throwable since it includes errors. 90
Local variable 'value' could be declared final 106108
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 121
Found non-transient, non-static member. Please mark as transient or provide accessors. 146
Found non-transient, non-static member. Please mark as transient or provide accessors. 162

org/andromda/core/common/TemplateObjectException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 18
Parameter 'message' is not assigned and could be declared final 28
Parameter 'message' is not assigned and could be declared final 40
Parameter 'parent' is not assigned and could be declared final 41

org/andromda/core/common/XmlObjectFactory.java

Violation Line
Variables that are final and static should be all capitals, 'logger' is not all capitals. 57
Private field 'digester' could be made final; it is only initialized in the declaration or constructor. 72
Found non-transient, non-static member. Please mark as transient or provide accessors. 72
Avoid using redundant field initializer for 'digester' 72
Avoid using redundant field initializer for 'objectClass' 77
Found non-transient, non-static member. Please mark as transient or provide accessors. 77
Found non-transient, non-static member. Please mark as transient or provide accessors. 82
Avoid using redundant field initializer for 'objectRulesXml' 82
Avoid using redundant field initializer for 'schemaUri' 87
Found non-transient, non-static member. Please mark as transient or provide accessors. 87
Variables that are final and static should be all capitals, 'factoryCache' is not all capitals. 98
Deeply nested if..then statements are hard to read 182186
Assigning an Object to null is a code smell. Consider refactoring. 190
Deeply nested if..then statements are hard to read 194197
Deeply nested if..then statements are hard to read 199204
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 215
Avoid if (x != y) ..; else ..; 235
Parameter 'objectXml' is not assigned and could be declared final 256
Avoid reassigning parameters such as 'objectXml' 272
Assigning an Object to null is a code smell. Consider refactoring. 283
New exception is thrown in catch block, original stack trace may be lost 302
New exception is thrown in catch block, original stack trace may be lost 304
A catch statement should never catch throwable since it includes errors. 306
Unnecessary final modifier in final class 323327
Unnecessary final modifier in final class 332336
Unnecessary final modifier in final class 341344
Found non-transient, non-static member. Please mark as transient or provide accessors. 378
Private field 'xmlResource' could be made final; it is only initialized in the declaration or constructor. 378
This call to String.startsWith can be rewritten using String.charAt(0) 408
Deeply nested if..then statements are hard to read 408413
Deeply nested if..then statements are hard to read 425428
Avoid empty catch blocks 430433
Deeply nested if..then statements are hard to read 434448
Avoid empty catch blocks 444447
Deeply nested if..then statements are hard to read 449454
StringBuffer constructor is initialized with size 16, but has at least 55 characters appended. 468
Local variable 'builder' could be declared final 468
Avoid appending characters as strings in StringBuffer.append. 472

org/andromda/core/common/XmlObjectFactoryException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/configuration/Configuration.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 81
Found non-transient, non-static member. Please mark as transient or provide accessors. 106
Found non-transient, non-static member. Please mark as transient or provide accessors. 132
Found non-transient, non-static member. Please mark as transient or provide accessors. 184
Avoid using redundant field initializer for 'contents' 231
A catch statement should never catch throwable since it includes errors. 297
Avoid empty catch blocks 297301

org/andromda/core/configuration/ConfigurationException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39
Parameter 'parent' is not assigned and could be declared final 49

org/andromda/core/configuration/Filter.java

Violation Line
Private field 'namespaces' could be made final; it is only initialized in the declaration or constructor. 66
Found non-transient, non-static member. Please mark as transient or provide accessors. 66
Parameter 'namespaces' is not assigned and could be declared final 73

org/andromda/core/configuration/Filters.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 27
It is somewhat confusing to have a field name matching the declaring class name 44
Found non-transient, non-static member. Please mark as transient or provide accessors. 44
Found non-transient, non-static member. Please mark as transient or provide accessors. 77
Local variable 'filter' could be declared final 90
Avoid reassigning parameters such as 'value' 126
Avoid reassigning parameters such as 'pattern' 127
Avoid reassigning parameters such as 'pattern' 127
Avoid reassigning parameters such as 'pattern' 127
Local variable 'matchAll' could be declared final 138

org/andromda/core/configuration/Location.java

Violation Line
Parameter 'path' is not assigned and could be declared final 45
Parameter 'patterns' is not assigned and could be declared final 65
Avoid if (x != y) ..; else ..; 81109
Local variable 'patterns' could be declared final 89
Avoid if (x != y) ..; else ..; 89
Local variable 'path' could be declared final 95

org/andromda/core/configuration/Model.java

Violation Line
Avoid using redundant field initializer for 'lastModifiedCheck' 30
Found non-transient, non-static member. Please mark as transient or provide accessors. 132
Private field 'uris' could be made final; it is only initialized in the declaration or constructor. 132
Found non-transient, non-static member. Please mark as transient or provide accessors. 138
Avoid using redundant field initializer for 'urisAsStrings' 138
Avoid empty catch blocks 179182
A catch statement should never catch throwable since it includes errors. 185
Found non-transient, non-static member. Please mark as transient or provide accessors. 194
Found non-transient, non-static member. Please mark as transient or provide accessors. 219
Found non-transient, non-static member. Please mark as transient or provide accessors. 291
Avoid using redundant field initializer for 'moduleSearchLocationPaths' 291
Avoid using redundant field initializer for 'moduleSearchLocationResources' 323
Found non-transient, non-static member. Please mark as transient or provide accessors. 323
Variables that are final and static should be all capitals, 'modelModifiedTimes' is not all capitals. 386
Avoid using redundant field initializer for 'key' 391
Found non-transient, non-static member. Please mark as transient or provide accessors. 391
Use explicit scoping instead of the default package private level 439442
Local variable 'lastModifiedTimes' could be declared final 456
Deeply nested if..then statements are hard to read 464481
These nested if statements could be combined 474478
Use explicit scoping instead of the default package private level 531534

org/andromda/core/configuration/Namespace.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 48
Assigning an Object to null is a code smell. Consider refactoring. 95

org/andromda/core/configuration/NamespaceProperties.java

Violation Line
An Interface should be used only to model a behaviour; consider converting this to a class. 836
Avoid modifiers which are implied by the context 14
Avoid modifiers which are implied by the context 21
Avoid modifiers which are implied by the context 27
Avoid modifiers which are implied by the context 35

org/andromda/core/configuration/Namespaces.java

Violation Line
Variables that are final and static should be all capitals, 'logger' is not all capitals. 30
Found non-transient, non-static member. Please mark as transient or provide accessors. 42
It is somewhat confusing to have a field name matching the declaring class name 42
Field instance has the same name as a method 47
Avoid using redundant field initializer for 'instance' 47
Singleton is not thread safe 5659
Assigning an Object to null is a code smell. Consider refactoring. 142
Assigning an Object to null is a code smell. Consider refactoring. 185
Found non-transient, non-static member. Please mark as transient or provide accessors. 265
Local variable 'warning' could be declared final 349
Avoid if (x != y) ..; else ..; 354

org/andromda/core/configuration/Property.java

Violation Line
Avoid using redundant field initializer for 'ignore' 73

org/andromda/core/configuration/Repository.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 46

org/andromda/core/configuration/Server.java

Violation Line
Parameter 'host' is not assigned and could be declared final 65

org/andromda/core/engine/Engine.java

Violation Line
Private field 'modelProcessor' could be made final; it is only initialized in the declaration or constructor. 31
Found non-transient, non-static member. Please mark as transient or provide accessors. 31
Parameter 'lastModifiedCheck' is not assigned and could be declared final 84

org/andromda/core/engine/ModelProcessor.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 1881
Variables that are final and static should be all capitals, 'logger' is not all capitals. 54
Avoid if (x != y) ..; else ..; 8586
Local variable 'property' could be declared final 104
A catch statement should never catch throwable since it includes errors. 113
Local variable 'repository' could be declared final 134
Found non-transient, non-static member. Please mark as transient or provide accessors. 167
Found non-transient, non-static member. Please mark as transient or provide accessors. 172
Found non-transient, non-static member. Please mark as transient or provide accessors. 177
Found non-transient, non-static member. Please mark as transient or provide accessors. 183
Avoid using redundant field initializer for 'historyDir' 188
Found non-transient, non-static member. Please mark as transient or provide accessors. 188
Parameter 'lastModifiedCheck' is not assigned and could be declared final 193
Parameter 'historyDir' is not assigned and could be declared final 201
Avoid really long methods. 214314
Local variable 'model' could be declared final 228
Local variable 'namespace' could be declared final 256
Local variable 'model' could be declared final 269
A catch statement that catches an exception only to rethrow it should be avoided. 291295
A catch statement should never catch throwable since it includes errors. 296
Local variable 'cartridge' could be declared final 325
Avoid if (x != y) ..; else ..; 389
Avoid if (x != y) ..; else ..; 411
Local variable 'cartridge' could be declared final 426
Useless parentheses. 473
Local variable 'message' could be declared final 492
Avoid using redundant field initializer for 'currentConfiguration' 508
Found non-transient, non-static member. Please mark as transient or provide accessors. 508
Use bitwise inversion to invert boolean values 527
Use explicit scoping instead of the default package private level 539553
Unnecessary use of fully qualified name 'org.andromda.core.configuration.Repository' due to existing import 'org.andromda.core.configuration.Repository' 539
Local variable 'repository' could be declared final 544
Local variable 'model' could be declared final 566
A getX() method which returns a boolean should be named isX() 613616
Found non-transient, non-static member. Please mark as transient or provide accessors. 622
Avoid using redundant field initializer for 'cartridgeFilter' 637
Found non-transient, non-static member. Please mark as transient or provide accessors. 637
Found non-transient, non-static member. Please mark as transient or provide accessors. 642
Avoid using redundant field initializer for 'negateCartridgeFilter' 642
Avoid reassigning parameters such as 'namespaces' 682
Avoid reassigning parameters such as 'namespaces' 682
Parameter 'o' is not assigned and could be declared final 752
Avoid variables with short names like o 752
Assigning an Object to null is a code smell. Consider refactoring. 795
Parameter 'o' is not assigned and could be declared final 818
Avoid variables with short names like o 818
Local variable 'message' could be declared final 819
Found non-transient, non-static member. Please mark as transient or provide accessors. 842
Found non-transient, non-static member. Please mark as transient or provide accessors. 865

org/andromda/core/engine/ModelProcessorException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 17
Parameter 'message' is not assigned and could be declared final 27
Parameter 'message' is not assigned and could be declared final 39
Parameter 'parent' is not assigned and could be declared final 40

org/andromda/core/mapping/Mapping.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 27
Avoid variables with short names like to 57
Avoid instantiating new objects inside loops 70
Found non-transient, non-static member. Please mark as transient or provide accessors. 84
Avoid variables with short names like to 98
Avoid variables with short names like to 106
Found non-transient, non-static member. Please mark as transient or provide accessors. 114
Use explicit scoping instead of the default package private level 122125
Local variable 'fromIterator' could be declared final 136

org/andromda/core/mapping/Mappings.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 38
It is somewhat confusing to have a field name matching the declaring class name 38
Variables that are final and static should be all capitals, 'logicalMappings' is not all capitals. 43
Found non-transient, non-static member. Please mark as transient or provide accessors. 48
Avoid reassigning parameters such as 'mappingsUri' 57
A catch statement should never catch throwable since it includes errors. 79
A method/constructor shouldnt explicitly throw java.lang.Exception 97
A method/constructor shouldnt explicitly throw java.lang.Exception 122
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 138
Deeply nested if..then statements are hard to read 140143
A catch statement should never catch throwable since it includes errors. 192
A method/constructor shouldnt explicitly throw java.lang.Exception 206
Avoid using redundant field initializer for 'name' 301
Found non-transient, non-static member. Please mark as transient or provide accessors. 332
Parameter 'sourceMappings' is not assigned and could be declared final 390
Parameter 'targetMappings' is not assigned and could be declared final 390
Avoid reassigning parameters such as 'from' 408
Avoid variables with short names like to 412
Avoid variables with short names like to 463
Local variable 'mapping' could be declared final 465
A method should have only one exit point, and that should be the last statement in the method 469
Found non-transient, non-static member. Please mark as transient or provide accessors. 509
Use explicit scoping instead of the default package private level 518548

org/andromda/core/mapping/MappingsException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/metafacade/MetafacadeBase.java

Violation Line
Private field 'metaObject' could be made final; it is only initialized in the declaration or constructor. 25
Found non-transient, non-static member. Please mark as transient or provide accessors. 25
Avoid using redundant field initializer for 'initialized' 76
Use explicit scoping instead of the default package private level 8184
Use explicit scoping instead of the default package private level 9194
Comment is too large: Line too long 112
Found non-transient, non-static member. Please mark as transient or provide accessors. 186
Avoid using redundant field initializer for 'context' 186
Use explicit scoping instead of the default package private level 193201
Parameter 'contextIn' is not assigned and could be declared final 222
Avoid using redundant field initializer for 'metafacadeNamespace' 230
Found non-transient, non-static member. Please mark as transient or provide accessors. 230
Use explicit scoping instead of the default package private level 237240
Use explicit scoping instead of the default package private level 247250
The Logger variable declaration does not contain the static and final modifiers 309
Found non-transient, non-static member. Please mark as transient or provide accessors. 309
Use explicit scoping instead of the default package private level 316319
Found non-transient, non-static member. Please mark as transient or provide accessors. 324
Avoid using redundant field initializer for 'contextRoot' 324
Use explicit scoping instead of the default package private level 333336
Avoid using redundant field initializer for 'metafacadeName' 357
Found non-transient, non-static member. Please mark as transient or provide accessors. 357
Use explicit scoping instead of the default package private level 364371
Parameter 'object' is not assigned and could be declared final 377
Local variable 'that' could be declared final 382
Avoid using redundant field initializer for 'metafacadePropertyCachingEnabled' 400
Found non-transient, non-static member. Please mark as transient or provide accessors. 400
Avoid excessively long variable names like metafacadePropertyCachingEnabled 400
Found non-transient, non-static member. Please mark as transient or provide accessors. 422
Variables should start with a lowercase character, 'THIS' starts with uppercase character. 422
Field THIS has the same name as a method 422
The field name indicates a constant but its modifiers do not 422
Avoid using redundant field initializer for 'THIS' 422
Method names should not start with capital letters 433
Parameter 'object' is not assigned and could be declared final 451
No need to check for null before an instanceof 453
A method should have only one exit point, and that should be the last statement in the method 455
Local variable 'metafacade' could be declared final 457
A method should have only one exit point, and that should be the last statement in the method 460

org/andromda/core/metafacade/MetafacadeCache.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 36
Unnecessary final modifier in final class 4346
It is somewhat confusing to have a field name matching the declaring class name 51
Found non-transient, non-static member. Please mark as transient or provide accessors. 51
Unnecessary final modifier in final class 6681
Unnecessary final modifier in final class 90109
Unnecessary final modifier in final class 114117

org/andromda/core/metafacade/MetafacadeConstants.java

Violation Line
An Interface should be used only to model a behaviour; consider converting this to a class. 1022
Avoid modifiers which are implied by the context 15
Avoid modifiers which are implied by the context 21
Avoid excessively long variable names like METAFACADE_IMPLEMENTATION_SUFFIX 21

org/andromda/core/metafacade/MetafacadeException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/metafacade/MetafacadeFactory.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 35
Avoid using redundant field initializer for 'instance' 40
Singleton is not thread safe 5457
Found non-transient, non-static member. Please mark as transient or provide accessors. 64
Found non-transient, non-static member. Please mark as transient or provide accessors. 69
Found non-transient, non-static member. Please mark as transient or provide accessors. 83
Avoid reassigning parameters such as 'metafacadeClass' 157
Avoid reassigning parameters such as 'metafacadeClass' 157
Avoid declaring a variable if it is unreferenced before a possible exit point. 159
A method should have only one exit point, and that should be the last statement in the method 170
Avoid if (x != y) ..; else ..; 193208
A catch statement should never catch throwable since it includes errors. 231
A catch statement should never catch throwable since it includes errors. 288
A method/constructor shouldnt explicitly throw java.lang.Exception 316
Found non-transient, non-static member. Please mark as transient or provide accessors. 377
A catch statement should never catch throwable since it includes errors. 426
Private field 'metafacadeImpls' could be made final; it is only initialized in the declaration or constructor. 509
Found non-transient, non-static member. Please mark as transient or provide accessors. 509
Found non-transient, non-static member. Please mark as transient or provide accessors. 514
Use explicit scoping instead of the default package private level 539542
Unnecessary final modifier in final class 539542
Use explicit scoping instead of the default package private level 553581
Unnecessary final modifier in final class 553581
Unnecessary final modifier in final class 591601
Use explicit scoping instead of the default package private level 591601
Local variable 'namespace' could be declared final 614
Use explicit scoping instead of the default package private level 631637
Unnecessary final modifier in final class 631637
Avoid if (x != y) ..; else ..; 652
Use explicit scoping instead of the default package private level 663680
Unnecessary final modifier in final class 663680
Found non-transient, non-static member. Please mark as transient or provide accessors. 686
Found non-transient, non-static member. Please mark as transient or provide accessors. 703
Found non-transient, non-static member. Please mark as transient or provide accessors. 742
Assigning an Object to null is a code smell. Consider refactoring. 797
Assigning an Object to null is a code smell. Consider refactoring. 798
These nested if statements could be combined 812819

org/andromda/core/metafacade/MetafacadeFactoryException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/metafacade/MetafacadeImpls.java

Violation Line
Field instance has the same name as a method 35
Variables that are final and static should be all capitals, 'instance' is not all capitals. 35
Found non-transient, non-static member. Please mark as transient or provide accessors. 40
Found non-transient, non-static member. Please mark as transient or provide accessors. 55
Avoid excessively long variable names like METAFACADE_IMPLEMENTATION_SUFFIX 71
Avoid instantiating new objects inside loops 99
A catch statement should never catch throwable since it includes errors. 120
Deeply nested if..then statements are hard to read 159194
Avoid empty catch blocks 173176
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 173
Use explicit scoping instead of the default package private level 256
Found non-transient, non-static member. Please mark as transient or provide accessors. 256
Found non-transient, non-static member. Please mark as transient or provide accessors. 261
Use explicit scoping instead of the default package private level 261
Use explicit scoping instead of the default package private level 270291
A catch statement should never catch throwable since it includes errors. 286
Use explicit scoping instead of the default package private level 301322
Avoid excessively long variable names like metafacadeImplementationClassName 309
A catch statement should never catch throwable since it includes errors. 317
Use explicit scoping instead of the default package private level 327331

org/andromda/core/metafacade/MetafacadeImplsException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/metafacade/MetafacadeMapping.java

Violation Line
Avoid using redundant field initializer for 'metafacadeClass' 29
Found non-transient, non-static member. Please mark as transient or provide accessors. 29
A catch statement should never catch throwable since it includes errors. 52
Found non-transient, non-static member. Please mark as transient or provide accessors. 62
Use explicit scoping instead of the default package private level 8588
Avoid using redundant field initializer for 'contextRoot' 107
Found non-transient, non-static member. Please mark as transient or provide accessors. 136
Use explicit scoping instead of the default package private level 153160
Use explicit scoping instead of the default package private level 167170
Found non-transient, non-static member. Please mark as transient or provide accessors. 175
Found non-transient, non-static member. Please mark as transient or provide accessors. 201
Avoid using redundant field initializer for 'mappingProperties' 201
Comment is too large: Line too long 231
Found non-transient, non-static member. Please mark as transient or provide accessors. 234
Use explicit scoping instead of the default package private level 241244
Use explicit scoping instead of the default package private level 250253
Use explicit scoping instead of the default package private level 261264
Use explicit scoping instead of the default package private level 271274
Use explicit scoping instead of the default package private level 310313
Use explicit scoping instead of the default package private level 320323
Found non-transient, non-static member. Please mark as transient or provide accessors. 328
Use explicit scoping instead of the default package private level 336339
Use explicit scoping instead of the default package private level 346349
Use explicit scoping instead of the default package private level 357369
Found non-transient, non-static member. Please mark as transient or provide accessors. 390
Use explicit scoping instead of the default package private level 397406
Unnecessary final modifier in final class 397406
Unnecessary final modifier in final class 413416
Use explicit scoping instead of the default package private level 413416
Local variable 'separator' could be declared final 424
Found non-transient, non-static member. Please mark as transient or provide accessors. 447
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 447
Found non-transient, non-static member. Please mark as transient or provide accessors. 448
Private field 'value' could be made final; it is only initialized in the declaration or constructor. 448
Use explicit scoping instead of the default package private level 467470
Unnecessary final modifier in final class 467470
Unnecessary final modifier in final class 477480
Use explicit scoping instead of the default package private level 477480

org/andromda/core/metafacade/MetafacadeMappings.java

Violation Line
Avoid really long classes. 341223
The class 'MetafacadeMappings' has a Cyclomatic Complexity of 5 (Highest = 45). 341223
Found non-transient, non-static member. Please mark as transient or provide accessors. 43
Found non-transient, non-static member. Please mark as transient or provide accessors. 49
Avoid using redundant field initializer for 'defaultMetafacadeClass' 54
Avoid if (x != y) ..; else ..; 93103
Found non-transient, non-static member. Please mark as transient or provide accessors. 132
Found non-transient, non-static member. Please mark as transient or provide accessors. 159
Found non-transient, non-static member. Please mark as transient or provide accessors. 233
Avoid excessively long variable names like METAFACADE_PACKAGE_REPLACE_PATTERN 238
Local variable 'metafacadeInterfaces' could be declared final 263
Avoid if (x != y) ..; else ..; 272277
Found non-transient, non-static member. Please mark as transient or provide accessors. 303
Found non-transient, non-static member. Please mark as transient or provide accessors. 320
The method getMapping() has an NPath complexity of 1296555 357542
Avoid really long methods. 357542
The method 'getMapping' has a Cyclomatic Complexity of 45. 357542
Avoid if (x != y) ..; else ..; 363
These nested if statements could be combined 417432
Deeply nested if..then statements are hard to read 417432
Useless parentheses. 491
Avoid modifiers which are implied by the context 568575
Avoid modifiers which are implied by the context 574
Found non-transient, non-static member. Please mark as transient or provide accessors. 611
Local variable 'anInterface' could be declared final 629
Found non-transient, non-static member. Please mark as transient or provide accessors. 643
Local variable 'defaultPropertyReferences' could be declared final 736
Private field 'parents' could be made final; it is only initialized in the declaration or constructor. 789
Found non-transient, non-static member. Please mark as transient or provide accessors. 789
Use explicit scoping instead of the default package private level 850899
Local variable 'namespace1' could be declared final 854
Avoid instantiating new objects inside loops 859
Avoid instantiating new objects inside loops 863
Avoid really long methods. 9411045
The method initializeMappings() has an NPath complexity of 255 9411045
Avoid instantiating new objects inside loops 959
A catch statement should never catch throwable since it includes errors. 1040
Variables that are final and static should be all capitals, 'allMetafacadeMappingInstances' is not all capitals. 1050
Use explicit scoping instead of the default package private level 10581061
Found non-transient, non-static member. Please mark as transient or provide accessors. 1066
Private field 'metafacadeClasses' could be made final; it is only initialized in the declaration or constructor. 1066
Found non-transient, non-static member. Please mark as transient or provide accessors. 1071
Private field 'modelMetafacadeMappings' could be made final; it is only initialized in the declaration or constructor. 1071
Found non-transient, non-static member. Please mark as transient or provide accessors. 1095
Use explicit scoping instead of the default package private level 11031116
Local variable 'mappings' could be declared final 1106
A catch statement should never catch throwable since it includes errors. 1130
Use explicit scoping instead of the default package private level 11561182
These nested if statements could be combined 11691174
Use explicit scoping instead of the default package private level 11881204

org/andromda/core/metafacade/MetafacadeMappingsException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/metafacade/MetafacadeProperties.java

Violation Line
An Interface should be used only to model a behaviour; consider converting this to a class. 915
Avoid modifiers which are implied by the context 14
Avoid excessively long variable names like ENABLE_METAFACADE_PROPERTY_CACHING 14

org/andromda/core/metafacade/MetafacadeUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 24330
Use explicit scoping instead of the default package private level 33100
A catch statement should never catch throwable since it includes errors. 81
Use explicit scoping instead of the default package private level 112126
A method/constructor shouldnt explicitly throw java.lang.Exception 116
Comment is too large: Line too long 129
Parameter 'nameSet2' is not assigned and could be declared final 136
Parameter 'nameSet1' is not assigned and could be declared final 136
Local variable 'results' could be declared final 138
A method should have only one exit point, and that should be the last statement in the method 141
Local variable 'classesToName' could be declared final 144
Local variable 'classesSet1' could be declared final 145
Local variable 'classesSet2' could be declared final 146
Avoid instantiating new objects inside loops 150
Local variable 'classToCheckInterfaces' could be declared final 150
Local variable 'expectedResultNotCompliant' could be declared final 163170
Avoid instantiating new objects inside loops 163170
Parameter 'object' is not assigned and could be declared final 165
Avoid if (x != y) ..; else ..; 171186
Local variable 'expectedResultInterfaces' could be declared final 174
Avoid instantiating new objects inside loops 174
Local variable 'classToCheckNotCompliant' could be declared final 175182
Avoid instantiating new objects inside loops 175182
Parameter 'object' is not assigned and could be declared final 177
Comment is too large: Line too long 194
Comment is too large: Line too long 195
Comment is too large: Line too long 196
Parameter 'classesToName' is not assigned and could be declared final 202
Parameter 'nameSet' is not assigned and could be declared final 202
Avoid variables with short names like cl 209
Local variable 'cl' could be declared final 209
Comment is too large: Line too long 215
Avoid variables with short names like cl 223
Local variable 'cl' could be declared final 223
New exception is thrown in catch block, original stack trace may be lost 229
Avoid throwing raw exception types. 229
Local variable 'currentInterface' could be declared final 256
Local variable 'subInheritedMappingClassNames' could be declared final 258

org/andromda/core/metafacade/ModelAccessFacade.java

Violation Line
Avoid modifiers which are implied by the context 29
Avoid modifiers which are implied by the context 36
Avoid modifiers which are implied by the context 44
Avoid modifiers which are implied by the context 52
Avoid modifiers which are implied by the context 62
Avoid modifiers which are implied by the context 70
Avoid modifiers which are implied by the context 80
Avoid modifiers which are implied by the context 89

org/andromda/core/metafacade/ModelValidationMessage.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 59
Found non-transient, non-static member. Please mark as transient or provide accessors. 74
Found non-transient, non-static member. Please mark as transient or provide accessors. 89
Avoid using redundant field initializer for 'metafacadeName' 94
Found non-transient, non-static member. Please mark as transient or provide accessors. 94
Deeply nested if..then statements are hard to read 114118
Deeply nested if..then statements are hard to read 119122
Found non-transient, non-static member. Please mark as transient or provide accessors. 134
Avoid using redundant field initializer for 'metafacadeClass' 134
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 163
Parameter 'object' is not assigned and could be declared final 181

org/andromda/core/namespace/BaseNamespaceComponent.java

Violation Line
Abstract classes should be named AbstractXXX 1054

org/andromda/core/namespace/Component.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 43
Use explicit scoping instead of the default package private level 7278
Found non-transient, non-static member. Please mark as transient or provide accessors. 83

org/andromda/core/namespace/NamespaceComponent.java

Violation Line
Avoid modifiers which are implied by the context 17
Avoid modifiers which are implied by the context 24
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 40

org/andromda/core/namespace/NamespaceComponents.java

Violation Line
Field instance has the same name as a method 36
Singleton is not thread safe 4549
Avoid unnecessary constructors - the compiler will generate these for you 6466
Document empty constructor 6466
Avoid really long methods. 71182
The method discover() has an NPath complexity of 442 71182
Local variable 'requiresMerge' could be declared final 97
Avoid declaring a variable if it is unreferenced before a possible exit point. 144
Deeply nested if..then statements are hard to read 149154
Deeply nested if..then statements are hard to read 159166
Found non-transient, non-static member. Please mark as transient or provide accessors. 211
Private field 'registeredNamespaceResources' could be made final; it is only initialized in the declaration or constructor. 211
Private field 'registeredRegistries' could be made final; it is only initialized in the declaration or constructor. 216
Found non-transient, non-static member. Please mark as transient or provide accessors. 216
Avoid instantiating new objects inside loops 241
A catch statement should never catch throwable since it includes errors. 244
Assigning an Object to null is a code smell. Consider refactoring. 246
Avoid if (x != y) ..; else ..; 280282
Parameter 'path' is not assigned and could be declared final 309
Found non-transient, non-static member. Please mark as transient or provide accessors. 317
Assigning an Object to null is a code smell. Consider refactoring. 342
Found non-transient, non-static member. Please mark as transient or provide accessors. 362

org/andromda/core/namespace/NamespaceComponentsException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/namespace/NamespaceRegistry.java

Violation Line
Parameter 'name' is not assigned and could be declared final 38
Avoid using redundant field initializer for 'shared' 46
Found non-transient, non-static member. Please mark as transient or provide accessors. 74
Found non-transient, non-static member. Please mark as transient or provide accessors. 116
Local variable 'propertyDefinition' could be declared final 136
Use explicit scoping instead of the default package private level 148160
Private field 'resourceRoots' could be made final; it is only initialized in the declaration or constructor. 190
Found non-transient, non-static member. Please mark as transient or provide accessors. 190
Use explicit scoping instead of the default package private level 208211

org/andromda/core/profile/Profile.java

Violation Line
Field instance has the same name as a method 32
Singleton is not thread safe 4144
Found non-transient, non-static member. Please mark as transient or provide accessors. 51
Avoid reassigning parameters such as 'name' 74
Deeply nested if..then statements are hard to read 9396
Avoid if (x != y) ..; else ..; 99
Local variable 'namespace' could be declared final 110
Avoid if (x != y) ..; else ..; 133
A catch statement should never catch throwable since it includes errors. 141
Found non-transient, non-static member. Please mark as transient or provide accessors. 150
Avoid if (x != y) ..; else ..; 158
Assigning an Object to null is a code smell. Consider refactoring. 214

org/andromda/core/profile/ProfileException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39
Parameter 'parent' is not assigned and could be declared final 49

org/andromda/core/repository/Repositories.java

Violation Line
Field instance has the same name as a method 29
Singleton is not thread safe 3841
It is somewhat confusing to have a field name matching the declaring class name 48
Found non-transient, non-static member. Please mark as transient or provide accessors. 48
Deeply nested if..then statements are hard to read 7078
Local variable 'loaded' could be declared final 149
Avoid if (x != y) ..; else ..; 153
Local variable 'stream' could be declared final 188

org/andromda/core/repository/Repository.java

Violation Line
Avoid using redundant field initializer for 'implementation' 18
Found non-transient, non-static member. Please mark as transient or provide accessors. 18

org/andromda/core/repository/RepositoryException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 20
Parameter 'message' is not assigned and could be declared final 42
Parameter 'cause' is not assigned and could be declared final 43

org/andromda/core/repository/RepositoryFacade.java

Violation Line
Avoid modifiers which are implied by the context 21
Avoid modifiers which are implied by the context 26
Avoid modifiers which are implied by the context 3941
Comment is too large: Line too long 45
Avoid modifiers which are implied by the context 5356
Avoid modifiers which are implied by the context 6771
Avoid modifiers which are implied by the context 8285
Avoid modifiers which are implied by the context 94
Avoid modifiers which are implied by the context 100

org/andromda/core/repository/RepositoryFacadeException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 19
Parameter 'message' is not assigned and could be declared final 41
Parameter 'cause' is not assigned and could be declared final 42

org/andromda/core/server/Client.java

Violation Line
Avoid modifiers which are implied by the context 2223
Avoid modifiers which are implied by the context 3233

org/andromda/core/server/ClientException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 27
Parameter 'message' is not assigned and could be declared final 39
Parameter 'parent' is not assigned and could be declared final 40
Parameter 'parent' is not assigned and could be declared final 50

org/andromda/core/server/DefaultClient.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 74
Deeply nested if..then statements are hard to read 7784
A catch statement that catches an exception only to rethrow it should be avoided. 9095
A catch statement should never catch throwable since it includes errors. 96
Deeply nested if..then statements are hard to read 102112
Avoid empty catch blocks 108111

org/andromda/core/server/DefaultServer.java

Violation Line
Use explicit scoping instead of the default package private level 31
Avoid using redundant field initializer for 'listener' 36
Found non-transient, non-static member. Please mark as transient or provide accessors. 36
Found non-transient, non-static member. Please mark as transient or provide accessors. 41
Private field 'engine' could be made final; it is only initialized in the declaration or constructor. 41
Deeply nested if..then statements are hard to read 6063
New exception is thrown in catch block, original stack trace may be lost 6769
Avoid instantiating new objects inside loops 79
Avoid instantiating new objects inside loops 81
Deeply nested if..then statements are hard to read 8596
A catch statement should never catch throwable since it includes errors. 98
A catch statement should never catch throwable since it includes errors. 121
A catch statement should never catch throwable since it includes errors. 135
Found non-transient, non-static member. Please mark as transient or provide accessors. 146
Assigning an Object to null is a code smell. Consider refactoring. 172
Avoid empty catch blocks 175178

org/andromda/core/server/Server.java

Violation Line
Avoid modifiers which are implied by the context 21

org/andromda/core/server/ServerException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 19
Parameter 'message' is not assigned and could be declared final 31
Parameter 'parent' is not assigned and could be declared final 32
Parameter 'parent' is not assigned and could be declared final 42

org/andromda/core/templateengine/TemplateEngine.java

Violation Line
Avoid modifiers which are implied by the context 2526
A method/constructor shouldnt explicitly throw java.lang.Exception 26
Avoid modifiers which are implied by the context 3741
A method/constructor shouldnt explicitly throw java.lang.Exception 41
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 54
Avoid modifiers which are implied by the context 61
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 85

org/andromda/core/templateengine/TemplateEngineException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/transformation/Transformer.java

Violation Line
Avoid modifiers which are implied by the context 2325

org/andromda/core/transformation/XslTransformer.java

Violation Line
Avoid instantiating new objects inside loops 60
Avoid instantiating new objects inside loops 63
Avoid instantiating new objects inside loops 65
Avoid instantiating new objects inside loops 66
Avoid instantiating new objects inside loops 69
Avoid instantiating new objects inside loops 75
Deeply nested if..then statements are hard to read 7780
Local variable 'outputStream' could be declared final 81
Avoid instantiating new objects inside loops 81
Avoid instantiating new objects inside loops 89
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 100
Found non-transient, non-static member. Please mark as transient or provide accessors. 134
Parameter 'location' is not assigned and could be declared final 141

org/andromda/core/transformation/XslTransformerException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 19
Parameter 'message' is not assigned and could be declared final 29
Parameter 'message' is not assigned and could be declared final 41
Parameter 'parent' is not assigned and could be declared final 42

org/andromda/core/translation/Expression.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 17
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 17
Found non-transient, non-static member. Please mark as transient or provide accessors. 93
Private field 'originalExpression' could be made final; it is only initialized in the declaration or constructor. 93

org/andromda/core/translation/ExpressionException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/translation/ExpressionTranslator.java

Violation Line
Variables that are final and static should be all capitals, 'logger' is not all capitals. 19
Variables that are final and static should be all capitals, 'translator' is not all capitals. 20
Avoid if (x != y) ..; else ..; 7583
A catch statement should never catch throwable since it includes errors. 85

org/andromda/core/translation/TranslationUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 14184
Avoid unnecessary constructors - the compiler will generate these for you 2225
Avoid reassigning parameters such as 'string' 37
Avoid reassigning parameters such as 'string' 60
Avoid reassigning parameters such as 'property' 122
Local variable 'dotIndex' could be declared final 125
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 162

org/andromda/core/translation/Translator.java

Violation Line
Avoid modifiers which are implied by the context 2225

org/andromda/core/translation/TranslatorException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/translation/library/Fragment.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 28
Private field 'kinds' could be made final; it is only initialized in the declaration or constructor. 28
Avoid unnecessary constructors - the compiler will generate these for you 3639
Avoid reassigning parameters such as 'name' 77
Local variable 'kind' could be declared final 82

org/andromda/core/translation/library/Library.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 20
Avoid unnecessary constructors - the compiler will generate these for you 2528
A catch statement should never catch throwable since it includes errors. 79
Overriding method merely calls super 8891

org/andromda/core/translation/library/LibraryException.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 16
Parameter 'message' is not assigned and could be declared final 26
Parameter 'message' is not assigned and could be declared final 38
Parameter 'parent' is not assigned and could be declared final 39

org/andromda/core/translation/library/LibraryTranslation.java

Violation Line
Variables that are final and static should be all capitals, 'logger' is not all capitals. 29
Found non-transient, non-static member. Please mark as transient or provide accessors. 39
Found non-transient, non-static member. Please mark as transient or provide accessors. 139
Local variable 'handlerMethod' could be declared final 194
Deeply nested if..then statements are hard to read 195234
Local variable 'argTypes' could be declared final 197
Local variable 'args' could be declared final 200
Local variable 'errMsg' could be declared final 212215
A catch statement should never catch throwable since it includes errors. 218
Local variable 'trace' could be declared final 225
Prefer StringBuffer over += for concatenating strings 229
A catch statement should never catch throwable since it includes errors. 272
Avoid reassigning parameters such as 'templateContext' 287
A catch statement should never catch throwable since it includes errors. 319

org/andromda/core/translation/library/LibraryTranslationFinder.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 1579
Variables that are final and static should be all capitals, 'logger' is not all capitals. 19
Variables that are final and static should be all capitals, 'libraryTranslations' is not all capitals. 24
Local variable 'libSeparator' could be declared final 51
Local variable 'index' could be declared final 52
Deeply nested if..then statements are hard to read 6974

org/andromda/core/translation/library/Translation.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 20
Found non-transient, non-static member. Please mark as transient or provide accessors. 21
Local variable 'nextName' could be declared final 64
Avoid empty if statements 7584
Avoid reassigning parameters such as 'pattern' 140
Local variable 'nextIgnorePattern' could be declared final 146
Avoid reassigning parameters such as 'name' 166
Avoid reassigning parameters such as 'kind' 167
Local variable 'fragment' could be declared final 177
Local variable 'begin' could be declared final 182
Local variable 'beginLength' could be declared final 183
Local variable 'end' could be declared final 184
Local variable 'endIndex' could be declared final 191
Local variable 'toReplace' could be declared final 198
Avoid instantiating new objects inside loops 198