PMD Results

The following document contains the results of PMD 5.0.5.

Files

org/andromda/andromdapp/AndroMDApp.java

Violation Line
A catch statement should never catch throwable since it includes errors. 53
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 55
Use explicit scoping instead of the default package private level 66
Found non-transient, non-static member. Please mark as transient or provide accessors. 76
A method/constructor shouldnt explicitly throw java.lang.Exception 83
Found non-transient, non-static member. Please mark as transient or provide accessors. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
A method/constructor shouldnt explicitly throw java.lang.Exception 159
Local variable 'configuration' could be declared final 166
A catch statement should never catch throwable since it includes errors. 240
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 242

org/andromda/andromdapp/AndroMDAppType.java

Violation Line
The class 'AndroMDAppType' has a Cyclomatic Complexity of 3 (Highest = 28). 31–1004
Found non-transient, non-static member. Please mark as transient or provide accessors. 36
A method/constructor shouldnt explicitly throw java.lang.Exception 54
A method/constructor shouldnt explicitly throw java.lang.Exception 74
Avoid variables with short names like id 78
Found non-transient, non-static member. Please mark as transient or provide accessors. 195
Found non-transient, non-static member. Please mark as transient or provide accessors. 211
Avoid using redundant field initializer for 'templateEngine' 211
A method/constructor shouldnt explicitly throw java.lang.Exception 220
Found non-transient, non-static member. Please mark as transient or provide accessors. 237
Use explicit scoping instead of the default package private level 260–263
Avoid really long methods. 292–488
The method processResources() has an NPath complexity of 11760 292–488
The method 'processResources' has a Cyclomatic Complexity of 28. 292–488
A method/constructor shouldnt explicitly throw java.lang.Exception 293
Avoid instantiating new objects inside loops 320
Deeply nested if..then statements are hard to read 335–357
Avoid instantiating new objects inside loops 387–389
Avoid instantiating new objects inside loops 392
A catch statement should never catch throwable since it includes errors. 400
Avoid instantiating new objects inside loops 422–424
Deeply nested if..then statements are hard to read 429–433
Deeply nested if..then statements are hard to read 437–447
Avoid instantiating new objects inside loops 459
Local variable 'instructions' could be declared final 474–476
Avoid reassigning parameters such as 'path' 497
Avoid reassigning parameters such as 'path' 497
Avoid variables with short names like id 533
These nested if statements could be combined 600–612
Avoid reassigning parameters such as 'path' 623
Found non-transient, non-static member. Please mark as transient or provide accessors. 806
Use explicit scoping instead of the default package private level 813–816
Found non-transient, non-static member. Please mark as transient or provide accessors. 821
Found non-transient, non-static member. Please mark as transient or provide accessors. 847
Found non-transient, non-static member. Please mark as transient or provide accessors. 863
Found non-transient, non-static member. Please mark as transient or provide accessors. 879
Found non-transient, non-static member. Please mark as transient or provide accessors. 895
Found non-transient, non-static member. Please mark as transient or provide accessors. 909
Use explicit scoping instead of the default package private level 939–942
Use explicit scoping instead of the default package private level 949–952
Found non-transient, non-static member. Please mark as transient or provide accessors. 957
Use explicit scoping instead of the default package private level 974–977
Use explicit scoping instead of the default package private level 984–987

org/andromda/andromdapp/AndroMDAppUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 15–74
Avoid empty catch blocks 67–70

org/andromda/andromdapp/Condition.java

Violation Line
Avoid variables with short names like id 17
Avoid variables with short names like id 34
Found non-transient, non-static member. Please mark as transient or provide accessors. 42
Avoid variables with short names like id 54
Found non-transient, non-static member. Please mark as transient or provide accessors. 128
Avoid reassigning parameters such as 'value' 146

org/andromda/andromdapp/Conditions.java

Violation Line
Use explicit scoping instead of the default package private level 19
Use explicit scoping instead of the default package private level 24
Found non-transient, non-static member. Please mark as transient or provide accessors. 54
It is somewhat confusing to have a field name matching the declaring class name 54
Found non-transient, non-static member. Please mark as transient or provide accessors. 79
Use explicit scoping instead of the default package private level 101–104

org/andromda/andromdapp/Configuration.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 24
Found non-transient, non-static member. Please mark as transient or provide accessors. 45
Avoid instantiating new objects inside loops 82
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 90
Avoid empty catch blocks 90–93

org/andromda/andromdapp/Mapping.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 17
Avoid variables with short names like to 51
Avoid variables with short names like to 64

org/andromda/andromdapp/Prompt.java

Violation Line
Avoid variables with short names like id 17
Avoid variables with short names like id 34
Found non-transient, non-static member. Please mark as transient or provide accessors. 103
Useless parentheses. 128
Useless parentheses. 128
Found non-transient, non-static member. Please mark as transient or provide accessors. 149
Local variable 'response' could be declared final 170
Found non-transient, non-static member. Please mark as transient or provide accessors. 186
Found non-transient, non-static member. Please mark as transient or provide accessors. 212