PMD Results

The following document contains the results of PMD 5.0.5.

Files

org/andromda/cartridges/meta/MetaCartridgeUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 20–96
Parameter 'modelElements' is not assigned and could be declared final 27
Found non-transient, non-static member. Please mark as transient or provide accessors. 46
Local variable 'a' could be declared final 63
Avoid variables with short names like a 63
Local variable 'b' could be declared final 64
Avoid variables with short names like b 64
Avoid if (x != y) ..; else ..; 86

org/andromda/cartridges/meta/MetaProfile.java

Violation Line
Variables that are final and static should be all capitals, 'profile' is not all capitals. 18
Avoid excessively long variable names like TAGGEDVALUE_GENERALIZATION_PRECEDENCE 37

org/andromda/cartridges/meta/metafacades/ArgumentData.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 10
Private field 'fullyQualifiedTypeName' could be made final; it is only initialized in the declaration or constructor. 10
Found non-transient, non-static member. Please mark as transient or provide accessors. 11
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 11
Parameter 'fullyQualifiedTypeNameIn' is not assigned and could be declared final 17
Parameter 'nameIn' is not assigned and could be declared final 17

org/andromda/cartridges/meta/metafacades/MetaGlobals.java

Violation Line
Avoid excessively long variable names like PROPERTY_IMPLEMENTATION_OPERATION_NAME_PATTERN 14
Use explicit scoping instead of the default package private level 14–15
Use explicit scoping instead of the default package private level 20
Avoid excessively long variable names like PROPERTY_GENERALIZATION_NAME_PATTERN 20

org/andromda/cartridges/meta/metafacades/MetafacadeAssociationEndLogicImpl.java

Violation Line
Parameter 'metaObjectIn' is not assigned and could be declared final 20
Parameter 'context' is not assigned and could be declared final 21

org/andromda/cartridges/meta/metafacades/MetafacadeAttributeLogicImpl.java

Violation Line
Parameter 'metaObjectIn' is not assigned and could be declared final 20
Parameter 'context' is not assigned and could be declared final 21

org/andromda/cartridges/meta/metafacades/MetafacadeGeneralizationLogicImpl.java

Violation Line
Parameter 'metaObjectIn' is not assigned and could be declared final 24
Parameter 'context' is not assigned and could be declared final 25
Local variable 'value' could be declared final 37–39
Avoid empty catch blocks 46–49
These nested if statements could be combined 63–66
Local variable 'child' could be declared final 79
Local variable 'generalizations' could be declared final 84
Useless parentheses. 85
Useless parentheses. 85
Useless parentheses. 100

org/andromda/cartridges/meta/metafacades/MetafacadeLogicImpl.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 47
Avoid using redundant field initializer for 'featureMap' 47
Variables that are final and static should be all capitals, 'logger' is not all capitals. 51
Parameter 'metaObjectIn' is not assigned and could be declared final 58
Parameter 'context' is not assigned and could be declared final 59
Parameter 'classifier' is not assigned and could be declared final 85
Local variable 'dep' could be declared final 87
Local variable 'target' could be declared final 89
Local variable 'stereotypes' could be declared final 90
Useless parentheses. 91
Useless parentheses. 91
Local variable 'stereotypeName' could be declared final 93
A method should have only one exit point, and that should be the last statement in the method 96
Local variable 'superclass' could be declared final 101
Assigning an Object to null is a code smell. Consider refactoring. 102
Avoid if (x != y) ..; else ..; 102
Local variable 'dependencies' could be declared final 112
Useless parentheses. 113
Local variable 'dependency' could be declared final 116
Local variable 'targetElement' could be declared final 119
Deeply nested if..then statements are hard to read 120–123
Parameter 'name' is not assigned and could be declared final 217
Local variable 'fullyQualifiedName' could be declared final 219
Comment is too large: Line too long 229
Parameter 'facade' is not assigned and could be declared final 232
Local variable 'general' could be declared final 262
Avoid instantiating new objects inside loops 264
Local variable 'features' could be declared final 278
A catch statement should never catch throwable since it includes errors. 293
Avoid throwing raw exception types. 295
Avoid instantiating new objects inside loops 325–331
Avoid instantiating new objects inside loops 337–343
Local variable 'operation' could be declared final 359
Avoid instantiating new objects inside loops 361
A catch statement should never catch throwable since it includes errors. 375
Useless parentheses. 394
Parameter 'objectA' is not assigned and could be declared final 469
Parameter 'objectB' is not assigned and could be declared final 470
Avoid variables with short names like a 472
Local variable 'a' could be declared final 472
Avoid variables with short names like b 473
Local variable 'b' could be declared final 473
Local variable 'allParents' could be declared final 484
Local variable 'object' could be declared final 487

org/andromda/cartridges/meta/metafacades/MetafacadeOperationLogicImpl.java

Violation Line
Parameter 'metaObjectIn' is not assigned and could be declared final 21
Parameter 'context' is not assigned and could be declared final 22

org/andromda/cartridges/meta/metafacades/MethodData.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 16
Private field 'metafacadeName' could be made final; it is only initialized in the declaration or constructor. 16
Found non-transient, non-static member. Please mark as transient or provide accessors. 17
Private field 'visibility' could be made final; it is only initialized in the declaration or constructor. 17
Private field 'isAbstract' could be made final; it is only initialized in the declaration or constructor. 18
Field isAbstract has the same name as a method 18
Found non-transient, non-static member. Please mark as transient or provide accessors. 18
Found non-transient, non-static member. Please mark as transient or provide accessors. 19
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 19
Found non-transient, non-static member. Please mark as transient or provide accessors. 20
Private field 'returnTypeName' could be made final; it is only initialized in the declaration or constructor. 20
Found non-transient, non-static member. Please mark as transient or provide accessors. 21
Private field 'documentation' could be made final; it is only initialized in the declaration or constructor. 21
Found non-transient, non-static member. Please mark as transient or provide accessors. 22
Found non-transient, non-static member. Please mark as transient or provide accessors. 23
Parameter 'metafacadeNameIn' is not assigned and could be declared final 34
Parameter 'visibilityIn' is not assigned and could be declared final 35
Parameter 'isAbstractIn' is not assigned and could be declared final 36
Parameter 'returnTypeNameIn' is not assigned and could be declared final 37
Parameter 'nameIn' is not assigned and could be declared final 38
Parameter 'documentationIn' is not assigned and could be declared final 39
Parameter 'argument' is not assigned and could be declared final 52
Parameter 'typeName' is not assigned and could be declared final 68
Parameter 'suppressAbstractDeclaration' is not assigned and could be declared final 118
The String literal "" appears 4 times in this file; the first occurrence is on line 121 121
Useless parentheses. 121
Avoid if (x != y) ..; else ..; 122
Useless parentheses. 122
Prefer StringBuffer over += for concatenating strings 124
Prefer StringBuffer over += for concatenating strings 134
Prefer StringBuffer over += for concatenating strings 138
Local variable 'exception' could be declared final 141
Prefer StringBuffer over += for concatenating strings 142
Prefer StringBuffer over += for concatenating strings 145
The String literal ", " appears 5 times in this file; the first occurrence is on line 145 145
Parameter 'modifier' is not assigned and could be declared final 169
Prefer StringBuffer over += for concatenating strings 178
Prefer StringBuffer over += for concatenating strings 180
Useless parentheses. 180
Prefer StringBuffer over += for concatenating strings 183
Prefer StringBuffer over += for concatenating strings 201
Prefer StringBuffer over += for concatenating strings 204
Prefer StringBuffer over += for concatenating strings 207
Avoid if (x != y) ..; else ..; 219
Useless parentheses. 219
Prefer StringBuffer over += for concatenating strings 224
Prefer StringBuffer over += for concatenating strings 227
Prefer StringBuffer over += for concatenating strings 230
Local variable 'other' could be declared final 280
Avoid if (x != y) ..; else ..; 284–285
Useless parentheses. 284

org/andromda/cartridges/meta/metafacades/PSMmetaclassLogicImpl.java

Violation Line
Comment is too large: Line too long 3
Parameter 'context' is not assigned and could be declared final 17
Parameter 'metaObjectIn' is not assigned and could be declared final 17
Local variable 'operation' could be declared final 46

org/andromda/cartridges/meta/metafacades/UMLOperationData.java

Violation Line
Local variable 'parameter' could be declared final 31
Avoid instantiating new objects inside loops 34–36

org/andromda/cartridges/meta/metafacades/Metafacade.java

Violation Line
Avoid modifiers which are implied by the context 24
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 36
Avoid modifiers which are implied by the context 42
Avoid modifiers which are implied by the context 48
Avoid modifiers which are implied by the context 54
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 66
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 78
Avoid modifiers which are implied by the context 96
Avoid modifiers which are implied by the context 102
Avoid modifiers which are implied by the context 110
Avoid modifiers which are implied by the context 117
Avoid modifiers which are implied by the context 124
Avoid modifiers which are implied by the context 133

org/andromda/cartridges/meta/metafacades/MetafacadeAssociationEnd.java

Violation Line
Avoid modifiers which are implied by the context 22
Avoid modifiers which are implied by the context 29

org/andromda/cartridges/meta/metafacades/MetafacadeAssociationEndLogic.java

Violation Line
This class has a bunch of public methods and attributes 5–964
Abstract classes should be named AbstractXXX 32–964
Found non-transient, non-static member. Please mark as transient or provide accessors. 40
Parameter 'metaObjectIn' is not assigned and could be declared final 46
Parameter 'context' is not assigned and could be declared final 46
Avoid reassigning parameters such as 'context' 63
Found non-transient, non-static member. Please mark as transient or provide accessors. 72
Private field 'superAssociationEndFacade' could be made final; it is only initialized in the declaration or constructor. 72
Avoid using redundant field initializer for 'superAssociationEndFacadeInitialized' 73
Found non-transient, non-static member. Please mark as transient or provide accessors. 73
Avoid excessively long variable names like superAssociationEndFacadeInitialized 73
Avoid reassigning parameters such as 'context' 94
An empty method in an abstract class should be abstract instead 111–114
Found non-transient, non-static member. Please mark as transient or provide accessors. 124
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__implementationOperationName1a' is not final. 124
Found non-transient, non-static member. Please mark as transient or provide accessors. 125
Avoid using redundant field initializer for '__implementationOperationName1aSet' 125
Avoid excessively long variable names like __implementationOperationName1aSet 125
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__implementationOperationName1aSet' is not final. 125
An empty method in an abstract class should be abstract instead 153–156
An empty method in an abstract class should be abstract instead 162–165
Parameter 'element' is not assigned and could be declared final 447
Parameter 'tagName' is not assigned and could be declared final 457
Parameter 'tagName' is not assigned and could be declared final 467
Parameter 'bindedElement' is not assigned and could be declared final 478
Parameter 'kind' is not assigned and could be declared final 497
Parameter 'indent' is not assigned and could be declared final 508
Parameter 'indent' is not assigned and could be declared final 520
Parameter 'lineLength' is not assigned and could be declared final 520
Parameter 'indent' is not assigned and could be declared final 531
Parameter 'lineLength' is not assigned and could be declared final 531
Parameter 'htmlStyle' is not assigned and could be declared final 531
Parameter 'modelName' is not assigned and could be declared final 552
Parameter 'modelName' is not assigned and could be declared final 649
Parameter 'parameterName' is not assigned and could be declared final 743
Parameter 'stereotypeName' is not assigned and could be declared final 772
Parameter 'keywordName' is not assigned and could be declared final 782
Parameter 'stereotypeName' is not assigned and could be declared final 799
Parameter 'translation' is not assigned and could be declared final 868
Parameter 'name' is not assigned and could be declared final 868
Parameter 'translation' is not assigned and could be declared final 877
Parameter 'kind' is not assigned and could be declared final 886
Parameter 'translation' is not assigned and could be declared final 886
Local variable 'owner' could be declared final 907
Consider simply returning the value vs storing it in local variable 'owner' 908
Local variable 'name' could be declared final 918
Consider simply returning the value vs storing it in local variable 'name' 919
Parameter 'validationMessages' is not assigned and could be declared final 927
Avoid appending characters as strings in StringBuffer.append. 945
A catch statement should never catch throwable since it includes errors. 950
Avoid empty catch blocks 956–959
A catch statement should never catch throwable since it includes errors. 956
Avoid appending characters as strings in StringBuffer.append. 961

org/andromda/cartridges/meta/metafacades/MetafacadeAttribute.java

Violation Line
Avoid modifiers which are implied by the context 22
Avoid modifiers which are implied by the context 28

org/andromda/cartridges/meta/metafacades/MetafacadeAttributeLogic.java

Violation Line
This class has a bunch of public methods and attributes 5–935
Abstract classes should be named AbstractXXX 32–935
Found non-transient, non-static member. Please mark as transient or provide accessors. 40
Parameter 'context' is not assigned and could be declared final 46
Parameter 'metaObjectIn' is not assigned and could be declared final 46
Avoid reassigning parameters such as 'context' 63
Found non-transient, non-static member. Please mark as transient or provide accessors. 72
Private field 'superAttributeFacade' could be made final; it is only initialized in the declaration or constructor. 72
Avoid using redundant field initializer for 'superAttributeFacadeInitialized' 73
Found non-transient, non-static member. Please mark as transient or provide accessors. 73
Avoid reassigning parameters such as 'context' 94
An empty method in an abstract class should be abstract instead 111–114
Found non-transient, non-static member. Please mark as transient or provide accessors. 124
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__implementationOperationName1a' is not final. 124
Avoid using redundant field initializer for '__implementationOperationName1aSet' 125
Found non-transient, non-static member. Please mark as transient or provide accessors. 125
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__implementationOperationName1aSet' is not final. 125
Avoid excessively long variable names like __implementationOperationName1aSet 125
An empty method in an abstract class should be abstract instead 152–155
An empty method in an abstract class should be abstract instead 161–164
Parameter 'follow' is not assigned and could be declared final 173
Parameter 'name' is not assigned and could be declared final 173
Parameter 'element' is not assigned and could be declared final 418
Parameter 'tagName' is not assigned and could be declared final 428
Parameter 'tagName' is not assigned and could be declared final 438
Parameter 'bindedElement' is not assigned and could be declared final 449
Parameter 'kind' is not assigned and could be declared final 468
Parameter 'indent' is not assigned and could be declared final 479
Parameter 'lineLength' is not assigned and could be declared final 491
Parameter 'indent' is not assigned and could be declared final 491
Parameter 'htmlStyle' is not assigned and could be declared final 502
Parameter 'lineLength' is not assigned and could be declared final 502
Parameter 'indent' is not assigned and could be declared final 502
Parameter 'modelName' is not assigned and could be declared final 523
Parameter 'modelName' is not assigned and could be declared final 620
Parameter 'parameterName' is not assigned and could be declared final 714
Parameter 'stereotypeName' is not assigned and could be declared final 743
Parameter 'keywordName' is not assigned and could be declared final 753
Parameter 'stereotypeName' is not assigned and could be declared final 770
Parameter 'translation' is not assigned and could be declared final 839
Parameter 'name' is not assigned and could be declared final 839
Parameter 'translation' is not assigned and could be declared final 848
Parameter 'kind' is not assigned and could be declared final 857
Parameter 'translation' is not assigned and could be declared final 857
Local variable 'owner' could be declared final 878
Consider simply returning the value vs storing it in local variable 'owner' 879
Local variable 'name' could be declared final 889
Consider simply returning the value vs storing it in local variable 'name' 890
Parameter 'validationMessages' is not assigned and could be declared final 898
Avoid appending characters as strings in StringBuffer.append. 916
A catch statement should never catch throwable since it includes errors. 921
A catch statement should never catch throwable since it includes errors. 927
Avoid empty catch blocks 927–930
Avoid appending characters as strings in StringBuffer.append. 932

org/andromda/cartridges/meta/metafacades/MetafacadeGeneralization.java

Violation Line
Avoid modifiers which are implied by the context 22
Avoid modifiers which are implied by the context 28
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 41

org/andromda/cartridges/meta/metafacades/MetafacadeGeneralizationLogic.java

Violation Line
This class has a bunch of public methods and attributes 5–766
Abstract classes should be named AbstractXXX 31–766
Found non-transient, non-static member. Please mark as transient or provide accessors. 39
Parameter 'metaObjectIn' is not assigned and could be declared final 45
Parameter 'context' is not assigned and could be declared final 45
Avoid reassigning parameters such as 'context' 62
Private field 'superGeneralizationFacade' could be made final; it is only initialized in the declaration or constructor. 71
Found non-transient, non-static member. Please mark as transient or provide accessors. 71
Avoid excessively long variable names like superGeneralizationFacadeInitialized 72
Found non-transient, non-static member. Please mark as transient or provide accessors. 72
Avoid using redundant field initializer for 'superGeneralizationFacadeInitialized' 72
Avoid reassigning parameters such as 'context' 93
An empty method in an abstract class should be abstract instead 110–113
Found non-transient, non-static member. Please mark as transient or provide accessors. 123
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__precedence1a' is not final. 123
Avoid using redundant field initializer for '__precedence1aSet' 124
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__precedence1aSet' is not final. 124
Found non-transient, non-static member. Please mark as transient or provide accessors. 124
Found non-transient, non-static member. Please mark as transient or provide accessors. 154
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__getterName2a' is not final. 154
Avoid using redundant field initializer for '__getterName2aSet' 155
Found non-transient, non-static member. Please mark as transient or provide accessors. 155
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__getterName2aSet' is not final. 155
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__getterNameVisibility3a' is not final. 184
Found non-transient, non-static member. Please mark as transient or provide accessors. 184
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__getterNameVisibility3aSet' is not final. 185
Found non-transient, non-static member. Please mark as transient or provide accessors. 185
Avoid using redundant field initializer for '__getterNameVisibility3aSet' 185
An empty method in an abstract class should be abstract instead 212–215
An empty method in an abstract class should be abstract instead 221–224
Parameter 'element' is not assigned and could be declared final 249
Parameter 'tagName' is not assigned and could be declared final 259
Parameter 'tagName' is not assigned and could be declared final 269
Parameter 'bindedElement' is not assigned and could be declared final 280
Parameter 'kind' is not assigned and could be declared final 299
Parameter 'indent' is not assigned and could be declared final 310
Parameter 'indent' is not assigned and could be declared final 322
Parameter 'lineLength' is not assigned and could be declared final 322
Parameter 'htmlStyle' is not assigned and could be declared final 333
Parameter 'lineLength' is not assigned and could be declared final 333
Parameter 'indent' is not assigned and could be declared final 333
Parameter 'modelName' is not assigned and could be declared final 354
Parameter 'modelName' is not assigned and could be declared final 451
Parameter 'parameterName' is not assigned and could be declared final 545
Parameter 'stereotypeName' is not assigned and could be declared final 574
Parameter 'keywordName' is not assigned and could be declared final 584
Parameter 'stereotypeName' is not assigned and could be declared final 601
Parameter 'translation' is not assigned and could be declared final 670
Parameter 'name' is not assigned and could be declared final 670
Parameter 'translation' is not assigned and could be declared final 679
Parameter 'translation' is not assigned and could be declared final 688
Parameter 'kind' is not assigned and could be declared final 688
Local variable 'owner' could be declared final 709
Consider simply returning the value vs storing it in local variable 'owner' 710
Local variable 'name' could be declared final 720
Consider simply returning the value vs storing it in local variable 'name' 721
Parameter 'validationMessages' is not assigned and could be declared final 729
Avoid appending characters as strings in StringBuffer.append. 747
A catch statement should never catch throwable since it includes errors. 752
A catch statement should never catch throwable since it includes errors. 758
Avoid empty catch blocks 758–761
Avoid appending characters as strings in StringBuffer.append. 763

org/andromda/cartridges/meta/metafacades/MetafacadeLogic.java

Violation Line
This class has a bunch of public methods and attributes 5–1856
Too many fields 42–1856
Abstract classes should be named AbstractXXX 42–1856
Avoid really long classes. 42–1856
Found non-transient, non-static member. Please mark as transient or provide accessors. 50
Parameter 'context' is not assigned and could be declared final 56
Parameter 'metaObjectIn' is not assigned and could be declared final 56
Variables that are final and static should be all capitals, 'logger' is not all capitals. 71
Avoid reassigning parameters such as 'context' 78
Found non-transient, non-static member. Please mark as transient or provide accessors. 87
Private field 'superClassifierFacade' could be made final; it is only initialized in the declaration or constructor. 87
Found non-transient, non-static member. Please mark as transient or provide accessors. 88
Avoid using redundant field initializer for 'superClassifierFacadeInitialized' 88
Avoid excessively long variable names like superClassifierFacadeInitialized 88
Avoid reassigning parameters such as 'context' 109
An empty method in an abstract class should be abstract instead 126–129
Found non-transient, non-static member. Please mark as transient or provide accessors. 139
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__logicName1a' is not final. 139
Avoid using redundant field initializer for '__logicName1aSet' 140
Found non-transient, non-static member. Please mark as transient or provide accessors. 140
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__logicName1aSet' is not final. 140
Found non-transient, non-static member. Please mark as transient or provide accessors. 169
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__logicImplName2a' is not final. 169
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__logicImplName2aSet' is not final. 170
Found non-transient, non-static member. Please mark as transient or provide accessors. 170
Avoid using redundant field initializer for '__logicImplName2aSet' 170
Found non-transient, non-static member. Please mark as transient or provide accessors. 199
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__metaclassDirectDependency3a' is not final. 199
Avoid excessively long variable names like __metaclassDirectDependency3aSet 200
Avoid using redundant field initializer for '__metaclassDirectDependency3aSet' 200
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__metaclassDirectDependency3aSet' is not final. 200
Found non-transient, non-static member. Please mark as transient or provide accessors. 200
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__fullyQualifiedLogicImplName4a' is not final. 230
Found non-transient, non-static member. Please mark as transient or provide accessors. 230
Avoid excessively long variable names like __fullyQualifiedLogicImplName4aSet 231
Avoid using redundant field initializer for '__fullyQualifiedLogicImplName4aSet' 231
Found non-transient, non-static member. Please mark as transient or provide accessors. 231
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__fullyQualifiedLogicImplName4aSet' is not final. 231
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__fullyQualifiedLogicName5a' is not final. 260
Found non-transient, non-static member. Please mark as transient or provide accessors. 260
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__fullyQualifiedLogicName5aSet' is not final. 261
Avoid using redundant field initializer for '__fullyQualifiedLogicName5aSet' 261
Found non-transient, non-static member. Please mark as transient or provide accessors. 261
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__logicFile6a' is not final. 290
Found non-transient, non-static member. Please mark as transient or provide accessors. 290
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__logicFile6aSet' is not final. 291
Avoid using redundant field initializer for '__logicFile6aSet' 291
Found non-transient, non-static member. Please mark as transient or provide accessors. 291
Found non-transient, non-static member. Please mark as transient or provide accessors. 320
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__logicImplFile7a' is not final. 320
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__logicImplFile7aSet' is not final. 321
Avoid using redundant field initializer for '__logicImplFile7aSet' 321
Found non-transient, non-static member. Please mark as transient or provide accessors. 321
Found non-transient, non-static member. Please mark as transient or provide accessors. 350
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__logicPackageName8a' is not final. 350
Found non-transient, non-static member. Please mark as transient or provide accessors. 351
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__logicPackageName8aSet' is not final. 351
Avoid using redundant field initializer for '__logicPackageName8aSet' 351
Avoid excessively long variable names like __requiresInheritanceDelegatation9a 380
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__requiresInheritanceDelegatation9a' is not final. 380
Found non-transient, non-static member. Please mark as transient or provide accessors. 380
Found non-transient, non-static member. Please mark as transient or provide accessors. 381
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__requiresInheritanceDelegatation9aSet' is not final. 381
Avoid excessively long variable names like __requiresInheritanceDelegatation9aSet 381
Avoid using redundant field initializer for '__requiresInheritanceDelegatation9aSet' 381
Avoid excessively long variable names like requiresInheritanceDelegatation9a 392
Avoid excessively long variable names like __constructorRequiresMetaclassCast10a 413
Found non-transient, non-static member. Please mark as transient or provide accessors. 413
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__constructorRequiresMetaclassCast10a' is not final. 413
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__constructorRequiresMetaclassCast10aSet' is not final. 414
Avoid excessively long variable names like __constructorRequiresMetaclassCast10aSet 414
Found non-transient, non-static member. Please mark as transient or provide accessors. 414
Avoid using redundant field initializer for '__constructorRequiresMetaclassCast10aSet' 414
Avoid excessively long variable names like constructorRequiresMetaclassCast10a 423
Found non-transient, non-static member. Please mark as transient or provide accessors. 444
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__generalizationCount11a' is not final. 444
Avoid using redundant field initializer for '__generalizationCount11aSet' 445
Found non-transient, non-static member. Please mark as transient or provide accessors. 445
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__generalizationCount11aSet' is not final. 445
Parameter 'superMetafacade' is not assigned and could be declared final 486
Local variable 'returnValue' could be declared final 489
Local variable 'returnValue' could be declared final 508
Found non-transient, non-static member. Please mark as transient or provide accessors. 515
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__getMetaclass1r' is not final. 515
Found non-transient, non-static member. Please mark as transient or provide accessors. 516
Avoid using redundant field initializer for '__getMetaclass1rSet' 516
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__getMetaclass1rSet' is not final. 516
Local variable 'result' could be declared final 529
Local variable 'shieldedResult' could be declared final 530
Local variable 'result' could be declared final 565
Local variable 'shieldedResult' could be declared final 566
An empty method in an abstract class should be abstract instead 590–593
An empty method in an abstract class should be abstract instead 599–602
An empty method in an abstract class should be abstract instead 608–611
Parameter 'name' is not assigned and could be declared final 618
Parameter 'follow' is not assigned and could be declared final 714
Parameter 'follow' is not assigned and could be declared final 811
Parameter 'follow' is not assigned and could be declared final 863
Parameter 'tagName' is not assigned and could be declared final 1169
Parameter 'follow' is not assigned and could be declared final 1169
Parameter 'element' is not assigned and could be declared final 1252
Parameter 'tagName' is not assigned and could be declared final 1262
Parameter 'tagName' is not assigned and could be declared final 1272
Parameter 'bindedElement' is not assigned and could be declared final 1283
Parameter 'kind' is not assigned and could be declared final 1302
Parameter 'indent' is not assigned and could be declared final 1313
Parameter 'lineLength' is not assigned and could be declared final 1325
Parameter 'indent' is not assigned and could be declared final 1325
Parameter 'htmlStyle' is not assigned and could be declared final 1336
Parameter 'lineLength' is not assigned and could be declared final 1336
Parameter 'indent' is not assigned and could be declared final 1336
Parameter 'modelName' is not assigned and could be declared final 1357
Parameter 'modelName' is not assigned and could be declared final 1454
Parameter 'parameterName' is not assigned and could be declared final 1548
Parameter 'stereotypeName' is not assigned and could be declared final 1577
Parameter 'keywordName' is not assigned and could be declared final 1587
Parameter 'stereotypeName' is not assigned and could be declared final 1604
Parameter 'name' is not assigned and could be declared final 1673
Parameter 'translation' is not assigned and could be declared final 1673
Parameter 'translation' is not assigned and could be declared final 1682
Parameter 'kind' is not assigned and could be declared final 1691
Parameter 'translation' is not assigned and could be declared final 1691
Local variable 'owner' could be declared final 1712
Consider simply returning the value vs storing it in local variable 'owner' 1713
Local variable 'name' could be declared final 1723
Consider simply returning the value vs storing it in local variable 'name' 1724
Comment is too large: Line too long 1728
Comment is too large: Line too long 1732
Comment is too large: Line too long 1736
Comment is too large: Line too long 1737
The method validateInvariants() has an NPath complexity of 845 1744–1822
Parameter 'validationMessages' is not assigned and could be declared final 1744
Unnecessary wrapper object creation 1750
Local variable 'constraintValid' could be declared final 1750
A catch statement should never catch throwable since it includes errors. 1760
Local variable 'cause' could be declared final 1762
Parameter 'object' is not assigned and could be declared final 1775
Unnecessary wrapper object creation 1775
Unnecessary wrapper object creation 1775
Local variable 'constraintValid' could be declared final 1775
A catch statement should never catch throwable since it includes errors. 1785
Local variable 'cause' could be declared final 1787
Local variable 'constraintValid' could be declared final 1800
A catch statement should never catch throwable since it includes errors. 1810
Local variable 'cause' could be declared final 1812
Avoid appending characters as strings in StringBuffer.append. 1837
A catch statement should never catch throwable since it includes errors. 1842
A catch statement should never catch throwable since it includes errors. 1848
Avoid empty catch blocks 1848–1851
Avoid appending characters as strings in StringBuffer.append. 1853

org/andromda/cartridges/meta/metafacades/MetafacadeOperation.java

Violation Line
Avoid modifiers which are implied by the context 22
Avoid modifiers which are implied by the context 28

org/andromda/cartridges/meta/metafacades/MetafacadeOperationLogic.java

Violation Line
This class has a bunch of public methods and attributes 5–1091
Avoid really long classes. 32–1091
Abstract classes should be named AbstractXXX 32–1091
Found non-transient, non-static member. Please mark as transient or provide accessors. 40
Parameter 'context' is not assigned and could be declared final 46
Parameter 'metaObjectIn' is not assigned and could be declared final 46
Avoid reassigning parameters such as 'context' 63
Found non-transient, non-static member. Please mark as transient or provide accessors. 72
Private field 'superOperationFacade' could be made final; it is only initialized in the declaration or constructor. 72
Avoid using redundant field initializer for 'superOperationFacadeInitialized' 73
Found non-transient, non-static member. Please mark as transient or provide accessors. 73
Avoid reassigning parameters such as 'context' 94
An empty method in an abstract class should be abstract instead 111–114
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__implementationName1a' is not final. 124
Found non-transient, non-static member. Please mark as transient or provide accessors. 124
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__implementationName1aSet' is not final. 125
Found non-transient, non-static member. Please mark as transient or provide accessors. 125
Avoid using redundant field initializer for '__implementationName1aSet' 125
An empty method in an abstract class should be abstract instead 152–155
An empty method in an abstract class should be abstract instead 161–164
Parameter 'element' is not assigned and could be declared final 171
Parameter 'tagName' is not assigned and could be declared final 181
Parameter 'tagName' is not assigned and could be declared final 191
Parameter 'bindedElement' is not assigned and could be declared final 202
Parameter 'kind' is not assigned and could be declared final 221
Parameter 'indent' is not assigned and could be declared final 232
Parameter 'indent' is not assigned and could be declared final 244
Parameter 'lineLength' is not assigned and could be declared final 244
Parameter 'indent' is not assigned and could be declared final 255
Parameter 'lineLength' is not assigned and could be declared final 255
Parameter 'htmlStyle' is not assigned and could be declared final 255
Parameter 'modelName' is not assigned and could be declared final 276
Parameter 'modelName' is not assigned and could be declared final 373
Parameter 'parameterName' is not assigned and could be declared final 467
Parameter 'stereotypeName' is not assigned and could be declared final 496
Parameter 'keywordName' is not assigned and could be declared final 506
Parameter 'stereotypeName' is not assigned and could be declared final 523
Parameter 'name' is not assigned and could be declared final 592
Parameter 'translation' is not assigned and could be declared final 592
Parameter 'translation' is not assigned and could be declared final 601
Parameter 'translation' is not assigned and could be declared final 610
Parameter 'kind' is not assigned and could be declared final 610
Parameter 'name' is not assigned and could be declared final 620
Parameter 'follow' is not assigned and could be declared final 631
Parameter 'name' is not assigned and could be declared final 631
Parameter 'initialExceptions' is not assigned and could be declared final 702
Parameter 'withArgumentNames' is not assigned and could be declared final 859
Parameter 'argumentModifier' is not assigned and could be declared final 869
Parameter 'modifier' is not assigned and could be declared final 888
Local variable 'owner' could be declared final 1034
Consider simply returning the value vs storing it in local variable 'owner' 1035
Local variable 'name' could be declared final 1045
Consider simply returning the value vs storing it in local variable 'name' 1046
Parameter 'validationMessages' is not assigned and could be declared final 1054
Avoid appending characters as strings in StringBuffer.append. 1072
A catch statement should never catch throwable since it includes errors. 1077
A catch statement should never catch throwable since it includes errors. 1083
Avoid empty catch blocks 1083–1086
Avoid appending characters as strings in StringBuffer.append. 1088

org/andromda/cartridges/meta/metafacades/PSMmetaclass.java

Violation Line
Avoid modifiers which are implied by the context 24
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 38

org/andromda/cartridges/meta/metafacades/PSMmetaclassLogic.java

Violation Line
This class has a bunch of public methods and attributes 5–1369
Abstract classes should be named AbstractXXX 38–1369
Avoid really long classes. 38–1369
Found non-transient, non-static member. Please mark as transient or provide accessors. 46
Parameter 'context' is not assigned and could be declared final 52
Parameter 'metaObjectIn' is not assigned and could be declared final 52
Avoid reassigning parameters such as 'context' 69
Found non-transient, non-static member. Please mark as transient or provide accessors. 78
Private field 'superClassifierFacade' could be made final; it is only initialized in the declaration or constructor. 78
Found non-transient, non-static member. Please mark as transient or provide accessors. 79
Avoid using redundant field initializer for 'superClassifierFacadeInitialized' 79
Avoid excessively long variable names like superClassifierFacadeInitialized 79
Avoid reassigning parameters such as 'context' 100
An empty method in an abstract class should be abstract instead 117–120
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__operationsPresent1a' is not final. 130
Found non-transient, non-static member. Please mark as transient or provide accessors. 130
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__operationsPresent1aSet' is not final. 131
Avoid using redundant field initializer for '__operationsPresent1aSet' 131
Found non-transient, non-static member. Please mark as transient or provide accessors. 131
Found non-transient, non-static member. Please mark as transient or provide accessors. 161
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__implMustBeAbstract2a' is not final. 161
Avoid using redundant field initializer for '__implMustBeAbstract2aSet' 162
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__implMustBeAbstract2aSet' is not final. 162
Found non-transient, non-static member. Please mark as transient or provide accessors. 162
An empty method in an abstract class should be abstract instead 190–193
An empty method in an abstract class should be abstract instead 199–202
An empty method in an abstract class should be abstract instead 208–211
Parameter 'name' is not assigned and could be declared final 218
Parameter 'follow' is not assigned and could be declared final 314
Parameter 'follow' is not assigned and could be declared final 411
Parameter 'follow' is not assigned and could be declared final 463
Parameter 'follow' is not assigned and could be declared final 769
Parameter 'tagName' is not assigned and could be declared final 769
Parameter 'element' is not assigned and could be declared final 852
Parameter 'tagName' is not assigned and could be declared final 862
Parameter 'tagName' is not assigned and could be declared final 872
Parameter 'bindedElement' is not assigned and could be declared final 883
Parameter 'kind' is not assigned and could be declared final 902
Parameter 'indent' is not assigned and could be declared final 913
Parameter 'indent' is not assigned and could be declared final 925
Parameter 'lineLength' is not assigned and could be declared final 925
Parameter 'indent' is not assigned and could be declared final 936
Parameter 'lineLength' is not assigned and could be declared final 936
Parameter 'htmlStyle' is not assigned and could be declared final 936
Parameter 'modelName' is not assigned and could be declared final 957
Parameter 'modelName' is not assigned and could be declared final 1054
Parameter 'parameterName' is not assigned and could be declared final 1148
Parameter 'stereotypeName' is not assigned and could be declared final 1177
Parameter 'keywordName' is not assigned and could be declared final 1187
Parameter 'stereotypeName' is not assigned and could be declared final 1204
Parameter 'name' is not assigned and could be declared final 1273
Parameter 'translation' is not assigned and could be declared final 1273
Parameter 'translation' is not assigned and could be declared final 1282
Parameter 'kind' is not assigned and could be declared final 1291
Parameter 'translation' is not assigned and could be declared final 1291
Local variable 'owner' could be declared final 1312
Consider simply returning the value vs storing it in local variable 'owner' 1313
Local variable 'name' could be declared final 1323
Consider simply returning the value vs storing it in local variable 'name' 1324
Parameter 'validationMessages' is not assigned and could be declared final 1332
Avoid appending characters as strings in StringBuffer.append. 1350
A catch statement should never catch throwable since it includes errors. 1355
Avoid empty catch blocks 1361–1364
A catch statement should never catch throwable since it includes errors. 1361
Avoid appending characters as strings in StringBuffer.append. 1366