The following document contains the results of PMD 5.0.5.
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 35 |
| Private field 'engine' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Parameter 'lastModifiedCheck' is not assigned and could be declared final | 166 |
| Avoid if (x != y) ..; else ..; | 169–213 |
| Avoid if (x != y) ..; else ..; | 176–201 |
| A catch statement should never catch throwable since it includes errors. | 182 |
| Avoid throwing raw exception types. | 194 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 22 |
| Private field 'server' could be made final; it is only initialized in the declaration or constructor. | 22 |
| A catch statement should never catch throwable since it includes errors. | 77 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 1–827 |
| Local variable 'resource' could be declared final | 63 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 78 |
| The String literal "template" appears 4 times in this file; the first occurrence is on line 98 | 98 |
| Avoid if (x != y) ..; else ..; | 103–130 |
| Local variable 'templateModelElement' could be declared final | 105 |
| Avoid really long methods. | 139–261 |
| Avoid if (x != y) ..; else ..; | 188–198 |
| Avoid instantiating new objects inside loops | 197 |
| Local variable 'metafacade' could be declared final | 213 |
| Avoid instantiating new objects inside loops | 215 |
| A catch statement should never catch throwable since it includes errors. | 255 |
| Local variable 'entry' could be declared final | 294 |
| Avoid really long methods. | 359–484 |
| Local variable 'postProcessor' could be declared final | 430 |
| Local variable 'lResult' could be declared final | 436 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 446 |
| A catch statement should never catch throwable since it includes errors. | 472 |
| These nested if statements could be combined | 513–527 |
| Useless parentheses. | 603 |
| These nested if statements could be combined | 607–613 |
| A catch statement should never catch throwable since it includes errors. | 618 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 633 |
| Parameter 'templateContext' is not assigned and could be declared final | 666 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 675 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 680 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 685 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 711 |
| Avoid using redundant field initializer for 'conditionsEvaluated' | 711 |
| Avoid if (x != y) ..; else ..; | 773 |
| StringBuffer constructor is initialized with size 16, but has at least 82 characters appended. | 818 |
| Local variable 'builder' could be declared final | 818 |
| Avoid appending characters as strings in StringBuffer.append. | 824 |
| Violation | Line |
|---|---|
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Parameter 'parent' is not assigned and could be declared final | 49 |
| Violation | Line |
|---|---|
| Avoid reassigning parameters such as 'outputPattern' | 82 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 104 |
| Avoid using redundant field initializer for 'overwrite' | 120 |
| Local variable 'builder' could be declared final | 259 |
| StringBuffer constructor is initialized with size 16, but has at least 95 characters appended. | 259 |
| Avoid appending characters as strings in StringBuffer.append. | 267 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 50 |
| Local variable 'type' could be declared final | 176 |
| Local variable 'property' could be declared final | 187 |
| Deeply nested if..then statements are hard to read | 194–199 |
| A catch statement should never catch throwable since it includes errors. | 203 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 23 |
| It is somewhat confusing to have a field name matching the declaring class name | 23 |
| Avoid reassigning parameters such as 'variable' | 41 |
| Local variable 'modelElement' could be declared final | 67 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 24–27 |
| Avoid using redundant field initializer for 'generateEmptyFiles' | 33 |
| Avoid reassigning parameters such as 'outputPattern' | 73 |
| Avoid using redundant field initializer for 'outputToSingleFile' | 135 |
| Local variable 'builder' could be declared final | 194 |
| StringBuffer constructor is initialized with size 16, but has at least 92 characters appended. | 194 |
| Avoid appending characters as strings in StringBuffer.append. | 200 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 207 |
| Avoid using redundant field initializer for 'supportedModelElements' | 207 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 17 |
| Parameter 'message' is not assigned and could be declared final | 27 |
| Parameter 'message' is not assigned and could be declared final | 39 |
| Parameter 'parent' is not assigned and could be declared final | 40 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 46 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 85 |
| Private field 'name' could be made final; it is only initialized in the declaration or constructor. | 85 |
| Private field 'variable' could be made final; it is only initialized in the declaration or constructor. | 86 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 86 |
| Private field 'value' could be made final; it is only initialized in the declaration or constructor. | 87 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 87 |
| Violation | Line |
|---|---|
| Class contains more than one logger. | 21–223 |
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 22–223 |
| The Logger variable declaration does not contain the static and final modifiers | 27 |
| Local variable 'defaultConfiguration' could be declared final | 35 |
| Local variable 'stream' could be declared final | 43 |
| A catch statement should never catch throwable since it includes errors. | 49 |
| Avoid throwing raw exception types. | 63 |
| Avoid using redundant field initializer for 'loggingConfigurationUri' | 71 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 94 |
| System.out.print is used | 97 |
| Avoid if (x != y) ..; else ..; | 113–120 |
| Parameter 'object' is not assigned and could be declared final | 195 |
| Parameter 'object' is not assigned and could be declared final | 203 |
| Parameter 'object' is not assigned and could be declared final | 211 |
| Parameter 'object' is not assigned and could be declared final | 219 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 22–283 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 29 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 34 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 40 |
| Avoid if (x != y) ..; else ..; | 50 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 65 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 117 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 132 |
| Avoid using redundant field initializer for 'templateEngine' | 132 |
| Avoid reassigning parameters such as 'templateContext' | 174 |
| Local variable 'templateObject' could be declared final | 196 |
| Avoid using redundant field initializer for 'contents' | 230 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 230 |
| Deeply nested if..then statements are hard to read | 247–250 |
| Violation | Line |
|---|---|
| Field INSTANCE has the same name as a method | 18 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 41 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 46 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 51 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 56 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 61 |
| Local variable 'stream' could be declared final | 80 |
| A catch statement should never catch throwable since it includes errors. | 90 |
| New exception is thrown in catch block, original stack trace may be lost | 93 |
| Violation | Line |
|---|---|
| Comment is too large: Line too long | 16 |
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 25–394 |
| A catch statement should never catch throwable since it includes errors. | 38 |
| Avoid if (x != y) ..; else ..; | 54 |
| A catch statement should never catch throwable since it includes errors. | 56 |
| Avoid reassigning parameters such as 'className' | 69 |
| Avoid reassigning parameters such as 'className' | 69 |
| A catch statement should never catch throwable since it includes errors. | 98 |
| Local variable 'field' could be declared final | 163 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 167 |
| Local variable 'fieldsNum' could be declared final | 193 |
| Avoid if (x != y) ..; else ..; | 204–214 |
| Local variable 'interfaces' could be declared final | 269 |
| Local variable 'directoryUri' could be declared final | 311 |
| Avoid empty catch blocks | 335–338 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 50 |
| Avoid using redundant field initializer for 'instance' | 55 |
| Field instance has the same name as a method | 55 |
| Singleton is not thread safe | 64–67 |
| Parameter 'implementation' is not assigned and could be declared final | 95 |
| The String literal "type" appears 5 times in this file; the first occurrence is on line 147 | 147 |
| A catch statement should never catch throwable since it includes errors. | 160 |
| The String literal "key" appears 4 times in this file; the first occurrence is on line 190 | 190 |
| A catch statement should never catch throwable since it includes errors. | 262 |
| A catch statement should never catch throwable since it includes errors. | 489 |
| A catch statement should never catch throwable since it includes errors. | 528 |
| A catch statement should never catch throwable since it includes errors. | 548 |
| A catch statement should never catch throwable since it includes errors. | 570 |
| Assigning an Object to null is a code smell. Consider refactoring. | 582 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 17–142 |
| Avoid reassigning parameters such as 'object' | 36 |
| Avoid reassigning parameters such as 'object' | 36 |
| Avoid reassigning parameters such as 'object' | 36 |
| Avoid reassigning parameters such as 'object' | 36 |
| Avoid reassigning parameters such as 'expectedType' | 37 |
| Avoid empty catch blocks | 66–69 |
| New exception is thrown in catch block, original stack trace may be lost | 82–83 |
| A catch statement should never catch throwable since it includes errors. | 88 |
| Local variable 'trace' could be declared final | 95 |
| Prefer StringBuffer over += for concatenating strings | 99 |
| Variables that are final and static should be all capitals, 'primitiveWrappers' is not all capitals. | 110 |
| Do not use the short type | 127 |
| Violation | Line |
|---|---|
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 23 |
| Use explicit scoping instead of the default package private level | 28 |
| Use explicit scoping instead of the default package private level | 33 |
| Use explicit scoping instead of the default package private level | 38 |
| Use explicit scoping instead of the default package private level | 43 |
| Variables that are final and static should be all capitals, 'exceptionDirectoryName' is not all capitals. | 48 |
| Avoid using redundant field initializer for 'exceptionDirectory' | 53 |
| When instantiating a SimpleDateFormat object, specify a Locale | 54 |
| Variables that are final and static should be all capitals, 'cvDateFormat' is not all capitals. | 54 |
| Variables that are final and static should be all capitals, 'random' is not all capitals. | 55 |
| Variables that are final and static should be all capitals, 'instance' is not all capitals. | 60 |
| Field instance has the same name as a method | 60 |
| Parameter 'throwable' is not assigned and could be declared final | 89 |
| Parameter 'errorMessage' is not assigned and could be declared final | 105 |
| Parameter 'throwable' is not assigned and could be declared final | 106 |
| Parameter 'message' is not assigned and could be declared final | 128 |
| Parameter 'throwable' is not assigned and could be declared final | 129 |
| Avoid reassigning parameters such as 'prefix' | 130 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 158 |
| A catch statement should never catch throwable since it includes errors. | 175 |
| Parameter 'prefix' is not assigned and could be declared final | 194 |
| Use block level rather than method level synchronization | 194–232 |
| Avoid instantiating new objects inside loops | 201 |
| Avoid instantiating new objects inside loops | 202 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 227 |
| Avoid empty catch blocks | 227–230 |
| Avoid empty catch blocks | 245–248 |
| A catch statement should never catch throwable since it includes errors. | 245 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 11–247 |
| Avoid reassigning parameters such as 'throwable' | 220 |
| Parameter 'stackDepth' is not assigned and could be declared final | 235 |
| Avoid throwing raw exception types. | 238 |
| Violation | Line |
|---|---|
| Parameter 'pFile' is not assigned and could be declared final | 22 |
| Parameter 'pSource' is not assigned and could be declared final | 34 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 34 |
| Parameter 'pPreviousData' is not assigned and could be declared final | 34 |
| Violation | Line |
|---|---|
| Field instance has the same name as a method | 25 |
| Avoid using redundant field initializer for 'instance' | 25 |
| Singleton is not thread safe | 34–37 |
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 44 |
| Use bitwise inversion to invert boolean values | 88 |
| A catch statement should never catch throwable since it includes errors. | 104 |
| Avoid reassigning parameters such as 'name' | 144 |
| Local variable 'names' could be declared final | 154 |
| Unnecessary final modifier in final class | 181–221 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 193 |
| Avoid catching NullPointerException; consider removing the cause of the NPE. | 193 |
| A method should have only one exit point, and that should be the last statement in the method | 195 |
| A method should have only one exit point, and that should be the last statement in the method | 199 |
| A catch statement that catches an exception only to rethrow it should be avoided. | 201–207 |
| A catch statement should never catch throwable since it includes errors. | 208 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 214 |
| Local variable 'dotIndex' could be declared final | 238 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 267 |
| Avoid if (x != y) ..; else ..; | 296 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 347 |
| Avoid if (x != y) ..; else ..; | 376 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 393 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 398 |
| Private field 'propertyNamePattern' could be made final; it is only initialized in the declaration or constructor. | 398 |
| Local variable 'dotIndex' could be declared final | 445 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 480 |
| A catch statement should never catch throwable since it includes errors. | 521 |
| Local variable 'trace' could be declared final | 528 |
| Prefer StringBuffer over += for concatenating strings | 532 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 536 |
| Avoid reassigning parameters such as 'value' | 559 |
| Useless parentheses. | 561 |
| A catch statement should never catch throwable since it includes errors. | 593 |
| Assigning an Object to null is a code smell. Consider refactoring. | 610 |
| Local variable 'builder' could be declared final | 619 |
| StringBuffer constructor is initialized with size 16, but has at least 109 characters appended. | 619 |
| Avoid appending characters as strings in StringBuffer.append. | 624 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 21 |
| Parameter 'message' is not assigned and could be declared final | 33 |
| Violation | Line |
|---|---|
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 30 |
| Variables that are final and static should be all capitals, 'instance' is not all capitals. | 35 |
| Field instance has the same name as a method | 35 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 40 |
| Avoid reassigning parameters such as 'string' | 66 |
| Avoid reassigning parameters such as 'string' | 66 |
| Deeply nested if..then statements are hard to read | 86–90 |
| Avoid variables with short names like to | 88 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 121 |
| Use bitwise inversion to invert boolean values | 143 |
| Assigning an Object to null is a code smell. Consider refactoring. | 170 |
| Avoid if (x != y) ..; else ..; | 170 |
| Local variable 'mergeMappingsUriValue' could be declared final | 170 |
| Deeply nested if..then statements are hard to read | 174–195 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 181 |
| Deeply nested if..then statements are hard to read | 196–199 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 18 |
| Parameter 'message' is not assigned and could be declared final | 28 |
| Parameter 'message' is not assigned and could be declared final | 40 |
| Parameter 'parent' is not assigned and could be declared final | 41 |
| Violation | Line |
|---|---|
| StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 18 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 18 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 19 |
| Private field 'maxLineWidth' could be made final; it is only initialized in the declaration or constructor. | 19 |
| Local variable 'tokenizer' could be declared final | 62 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 69 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 12–101 |
| Avoid reassigning parameters such as 'path' | 36 |
| Avoid reassigning parameters such as 'path' | 36 |
| Avoid reassigning parameters such as 'pattern' | 37 |
| Avoid reassigning parameters such as 'pattern' | 37 |
| Avoid reassigning parameters such as 'pattern' | 37 |
| Avoid reassigning parameters such as 'pattern' | 37 |
| Local variable 'matchAll' could be declared final | 62 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 23–24 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 24 |
| Avoid modifiers which are implied by the context | 30 |
| Avoid modifiers which are implied by the context | 37 |
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 59 |
| Violation | Line |
|---|---|
| Parameter 'message' is not assigned and could be declared final | 18 |
| Parameter 'message' is not assigned and could be declared final | 30 |
| Parameter 'parent' is not assigned and could be declared final | 31 |
| Parameter 'parent' is not assigned and could be declared final | 41 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 16 |
| Avoid modifiers which are implied by the context | 25 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 25 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 14–41 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 36 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 35–871 |
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 36 |
| Avoid if (x != y) ..; else ..; | 65 |
| Local variable 'resource' could be declared final | 65 |
| Avoid variables with short names like in | 80 |
| Avoid throwing raw exception types. | 90 |
| Avoid throwing raw exception types. | 109 |
| Avoid empty catch blocks | 141–144 |
| Avoid reassigning parameters such as 'filePath' | 179 |
| Parameter 'includeSubdirectories' is not assigned and could be declared final | 202 |
| Parameter 'includeSubdirectories' is not assigned and could be declared final | 251 |
| Local variable 'file' could be declared final | 254 |
| Parameter 'includeSubdirectories' is not assigned and could be declared final | 269 |
| Assigning an Object to null is a code smell. Consider refactoring. | 277 |
| Local variable 'zipFile' could be declared final | 321 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 335 |
| A catch statement that catches an exception only to rethrow it should be avoided. | 335–338 |
| A catch statement should never catch throwable since it includes errors. | 340 |
| Avoid throwing raw exception types. | 342 |
| A method should have only one exit point, and that should be the last statement in the method | 409 |
| Avoid empty catch blocks | 411–414 |
| Local variable 'uriConnection' could be declared final | 465 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 476 |
| Avoid reassigning parameters such as 'path' | 519 |
| Avoid empty catch blocks | 538–541 |
| The method resolveClasspathResource() has an NPath complexity of 12076 | 564–641 |
| Avoid reassigning parameters such as 'path' | 564 |
| Assigning an Object to null is a code smell. Consider refactoring. | 636 |
| Parameter 'absolute' is not assigned and could be declared final | 693 |
| Avoid if (x != y) ..; else ..; | 702–751 |
| Avoid if (x != y) ..; else ..; | 707–721 |
| Prefer StringBuffer over += for concatenating strings | 715 |
| Prefer StringBuffer over += for concatenating strings | 715 |
| Avoid if (x != y) ..; else ..; | 740–749 |
| Useless parentheses. | 768 |
| Parameter 'time' is not assigned and could be declared final | 796 |
| Local variable 'file' could be declared final | 801 |
| Avoid excessively long variable names like BACK_SLASH_NORMALIZATION_PATTERN | 815 |
| Avoid excessively long variable names like FORWARD_SLASH_NORMALIZATION_PATTERN | 820 |
| Avoid if (x != y) ..; else ..; | 831–836 |
| Violation | Line |
|---|---|
| Field instance has the same name as a method | 22 |
| Variables that are final and static should be all capitals, 'instance' is not all capitals. | 22 |
| Avoid if (x != y) ..; else ..; | 92 |
| Avoid reassigning parameters such as 'string' | 151 |
| Avoid reassigning parameters such as 'string' | 151 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 202 |
| Avoid using redundant field initializer for 'encoding' | 202 |
| Parameter 'encoding' is not assigned and could be declared final | 210 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 215 |
| StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 215 |
| Local variable 'lastSlash' could be declared final | 227 |
| Avoid using redundant field initializer for 'modelFile' | 239 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 239 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 244 |
| Avoid using redundant field initializer for 'writtenCount' | 244 |
| Avoid using redundant field initializer for 'historyDir' | 260 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 260 |
| Parameter 'historyDirIn' is not assigned and could be declared final | 275 |
| Parameter 'file' is not assigned and could be declared final | 299 |
| Parameter 'time' is not assigned and could be declared final | 315 |
| Local variable 'fileName' could be declared final | 326 |
| Avoid instantiating new objects inside loops | 330 |
| Local variable 'file' could be declared final | 330 |
| Deeply nested if..then statements are hard to read | 334–338 |
| Deeply nested if..then statements are hard to read | 339–342 |
| Violation | Line |
|---|---|
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 22 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 48 |
| A catch statement should never catch throwable since it includes errors. | 90 |
| Local variable 'value' could be declared final | 106–108 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 121 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 146 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 162 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 18 |
| Parameter 'message' is not assigned and could be declared final | 28 |
| Parameter 'message' is not assigned and could be declared final | 40 |
| Parameter 'parent' is not assigned and could be declared final | 41 |
| Violation | Line |
|---|---|
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 57 |
| Private field 'digester' could be made final; it is only initialized in the declaration or constructor. | 72 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 72 |
| Avoid using redundant field initializer for 'digester' | 72 |
| Avoid using redundant field initializer for 'objectClass' | 77 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 77 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 82 |
| Avoid using redundant field initializer for 'objectRulesXml' | 82 |
| Avoid using redundant field initializer for 'schemaUri' | 87 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 87 |
| Variables that are final and static should be all capitals, 'factoryCache' is not all capitals. | 98 |
| Deeply nested if..then statements are hard to read | 182–186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 190 |
| Deeply nested if..then statements are hard to read | 194–197 |
| Deeply nested if..then statements are hard to read | 199–204 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 215 |
| Avoid if (x != y) ..; else ..; | 235 |
| Parameter 'objectXml' is not assigned and could be declared final | 256 |
| Avoid reassigning parameters such as 'objectXml' | 272 |
| Assigning an Object to null is a code smell. Consider refactoring. | 283 |
| New exception is thrown in catch block, original stack trace may be lost | 302 |
| New exception is thrown in catch block, original stack trace may be lost | 304 |
| A catch statement should never catch throwable since it includes errors. | 306 |
| Unnecessary final modifier in final class | 323–327 |
| Unnecessary final modifier in final class | 332–336 |
| Unnecessary final modifier in final class | 341–344 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 378 |
| Private field 'xmlResource' could be made final; it is only initialized in the declaration or constructor. | 378 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 408 |
| Deeply nested if..then statements are hard to read | 408–413 |
| Deeply nested if..then statements are hard to read | 425–428 |
| Avoid empty catch blocks | 430–433 |
| Deeply nested if..then statements are hard to read | 434–448 |
| Avoid empty catch blocks | 444–447 |
| Deeply nested if..then statements are hard to read | 449–454 |
| StringBuffer constructor is initialized with size 16, but has at least 55 characters appended. | 468 |
| Local variable 'builder' could be declared final | 468 |
| Avoid appending characters as strings in StringBuffer.append. | 472 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 81 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 106 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 132 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 184 |
| Avoid using redundant field initializer for 'contents' | 231 |
| A catch statement should never catch throwable since it includes errors. | 297 |
| Avoid empty catch blocks | 297–301 |
| Violation | Line |
|---|---|
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Parameter 'parent' is not assigned and could be declared final | 49 |
| Violation | Line |
|---|---|
| Private field 'namespaces' could be made final; it is only initialized in the declaration or constructor. | 66 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 66 |
| Parameter 'namespaces' is not assigned and could be declared final | 73 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 27 |
| It is somewhat confusing to have a field name matching the declaring class name | 44 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 44 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 77 |
| Local variable 'filter' could be declared final | 90 |
| Avoid reassigning parameters such as 'value' | 126 |
| Avoid reassigning parameters such as 'pattern' | 127 |
| Avoid reassigning parameters such as 'pattern' | 127 |
| Avoid reassigning parameters such as 'pattern' | 127 |
| Local variable 'matchAll' could be declared final | 138 |
| Violation | Line |
|---|---|
| Parameter 'path' is not assigned and could be declared final | 45 |
| Parameter 'patterns' is not assigned and could be declared final | 65 |
| Avoid if (x != y) ..; else ..; | 81–109 |
| Local variable 'patterns' could be declared final | 89 |
| Avoid if (x != y) ..; else ..; | 89 |
| Local variable 'path' could be declared final | 95 |
| Violation | Line |
|---|---|
| Avoid using redundant field initializer for 'lastModifiedCheck' | 30 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 132 |
| Private field 'uris' could be made final; it is only initialized in the declaration or constructor. | 132 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 138 |
| Avoid using redundant field initializer for 'urisAsStrings' | 138 |
| Avoid empty catch blocks | 179–182 |
| A catch statement should never catch throwable since it includes errors. | 185 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 194 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 219 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 291 |
| Avoid using redundant field initializer for 'moduleSearchLocationPaths' | 291 |
| Avoid using redundant field initializer for 'moduleSearchLocationResources' | 323 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 323 |
| Variables that are final and static should be all capitals, 'modelModifiedTimes' is not all capitals. | 386 |
| Avoid using redundant field initializer for 'key' | 391 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 391 |
| Use explicit scoping instead of the default package private level | 439–442 |
| Local variable 'lastModifiedTimes' could be declared final | 456 |
| Deeply nested if..then statements are hard to read | 464–481 |
| These nested if statements could be combined | 474–478 |
| Use explicit scoping instead of the default package private level | 531–534 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 48 |
| Assigning an Object to null is a code smell. Consider refactoring. | 95 |
| Violation | Line |
|---|---|
| An Interface should be used only to model a behaviour; consider converting this to a class. | 8–36 |
| Avoid modifiers which are implied by the context | 14 |
| Avoid modifiers which are implied by the context | 21 |
| Avoid modifiers which are implied by the context | 27 |
| Avoid modifiers which are implied by the context | 35 |
| Violation | Line |
|---|---|
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 30 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 42 |
| It is somewhat confusing to have a field name matching the declaring class name | 42 |
| Field instance has the same name as a method | 47 |
| Avoid using redundant field initializer for 'instance' | 47 |
| Singleton is not thread safe | 56–59 |
| Assigning an Object to null is a code smell. Consider refactoring. | 142 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 265 |
| Local variable 'warning' could be declared final | 349 |
| Avoid if (x != y) ..; else ..; | 354 |
| Violation | Line |
|---|---|
| Avoid using redundant field initializer for 'ignore' | 73 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 46 |
| Violation | Line |
|---|---|
| Parameter 'host' is not assigned and could be declared final | 65 |
| Violation | Line |
|---|---|
| Private field 'modelProcessor' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 31 |
| Parameter 'lastModifiedCheck' is not assigned and could be declared final | 84 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 1–881 |
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 54 |
| Avoid if (x != y) ..; else ..; | 85–86 |
| Local variable 'property' could be declared final | 104 |
| A catch statement should never catch throwable since it includes errors. | 113 |
| Local variable 'repository' could be declared final | 134 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 167 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 172 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 177 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 183 |
| Avoid using redundant field initializer for 'historyDir' | 188 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 188 |
| Parameter 'lastModifiedCheck' is not assigned and could be declared final | 193 |
| Parameter 'historyDir' is not assigned and could be declared final | 201 |
| Avoid really long methods. | 214–314 |
| Local variable 'model' could be declared final | 228 |
| Local variable 'namespace' could be declared final | 256 |
| Local variable 'model' could be declared final | 269 |
| A catch statement that catches an exception only to rethrow it should be avoided. | 291–295 |
| A catch statement should never catch throwable since it includes errors. | 296 |
| Local variable 'cartridge' could be declared final | 325 |
| Avoid if (x != y) ..; else ..; | 389 |
| Avoid if (x != y) ..; else ..; | 411 |
| Local variable 'cartridge' could be declared final | 426 |
| Useless parentheses. | 473 |
| Local variable 'message' could be declared final | 492 |
| Avoid using redundant field initializer for 'currentConfiguration' | 508 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 508 |
| Use bitwise inversion to invert boolean values | 527 |
| Use explicit scoping instead of the default package private level | 539–553 |
| Unnecessary use of fully qualified name 'org.andromda.core.configuration.Repository' due to existing import 'org.andromda.core.configuration.Repository' | 539 |
| Local variable 'repository' could be declared final | 544 |
| Local variable 'model' could be declared final | 566 |
| A getX() method which returns a boolean should be named isX() | 613–616 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 622 |
| Avoid using redundant field initializer for 'cartridgeFilter' | 637 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 637 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 642 |
| Avoid using redundant field initializer for 'negateCartridgeFilter' | 642 |
| Avoid reassigning parameters such as 'namespaces' | 682 |
| Avoid reassigning parameters such as 'namespaces' | 682 |
| Parameter 'o' is not assigned and could be declared final | 752 |
| Avoid variables with short names like o | 752 |
| Assigning an Object to null is a code smell. Consider refactoring. | 795 |
| Parameter 'o' is not assigned and could be declared final | 818 |
| Avoid variables with short names like o | 818 |
| Local variable 'message' could be declared final | 819 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 842 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 865 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 17 |
| Parameter 'message' is not assigned and could be declared final | 27 |
| Parameter 'message' is not assigned and could be declared final | 39 |
| Parameter 'parent' is not assigned and could be declared final | 40 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 27 |
| Avoid variables with short names like to | 57 |
| Avoid instantiating new objects inside loops | 70 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 84 |
| Avoid variables with short names like to | 98 |
| Avoid variables with short names like to | 106 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 114 |
| Use explicit scoping instead of the default package private level | 122–125 |
| Local variable 'fromIterator' could be declared final | 136 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 38 |
| It is somewhat confusing to have a field name matching the declaring class name | 38 |
| Variables that are final and static should be all capitals, 'logicalMappings' is not all capitals. | 43 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 48 |
| Avoid reassigning parameters such as 'mappingsUri' | 57 |
| A catch statement should never catch throwable since it includes errors. | 79 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 97 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 122 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 138 |
| Deeply nested if..then statements are hard to read | 140–143 |
| A catch statement should never catch throwable since it includes errors. | 192 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 206 |
| Avoid using redundant field initializer for 'name' | 301 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 332 |
| Parameter 'sourceMappings' is not assigned and could be declared final | 390 |
| Parameter 'targetMappings' is not assigned and could be declared final | 390 |
| Avoid reassigning parameters such as 'from' | 408 |
| Avoid variables with short names like to | 412 |
| Avoid variables with short names like to | 463 |
| Local variable 'mapping' could be declared final | 465 |
| A method should have only one exit point, and that should be the last statement in the method | 469 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 509 |
| Use explicit scoping instead of the default package private level | 518–548 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Private field 'metaObject' could be made final; it is only initialized in the declaration or constructor. | 25 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 25 |
| Avoid using redundant field initializer for 'initialized' | 76 |
| Use explicit scoping instead of the default package private level | 81–84 |
| Use explicit scoping instead of the default package private level | 91–94 |
| Comment is too large: Line too long | 112 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 186 |
| Avoid using redundant field initializer for 'context' | 186 |
| Use explicit scoping instead of the default package private level | 193–201 |
| Parameter 'contextIn' is not assigned and could be declared final | 222 |
| Avoid using redundant field initializer for 'metafacadeNamespace' | 230 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 230 |
| Use explicit scoping instead of the default package private level | 237–240 |
| Use explicit scoping instead of the default package private level | 247–250 |
| The Logger variable declaration does not contain the static and final modifiers | 309 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 309 |
| Use explicit scoping instead of the default package private level | 316–319 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 324 |
| Avoid using redundant field initializer for 'contextRoot' | 324 |
| Use explicit scoping instead of the default package private level | 333–336 |
| Avoid using redundant field initializer for 'metafacadeName' | 357 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 357 |
| Use explicit scoping instead of the default package private level | 364–371 |
| Parameter 'object' is not assigned and could be declared final | 377 |
| Local variable 'that' could be declared final | 382 |
| Avoid using redundant field initializer for 'metafacadePropertyCachingEnabled' | 400 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 400 |
| Avoid excessively long variable names like metafacadePropertyCachingEnabled | 400 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 422 |
| Variables should start with a lowercase character, 'THIS' starts with uppercase character. | 422 |
| Field THIS has the same name as a method | 422 |
| The field name indicates a constant but its modifiers do not | 422 |
| Avoid using redundant field initializer for 'THIS' | 422 |
| Method names should not start with capital letters | 433 |
| Parameter 'object' is not assigned and could be declared final | 451 |
| No need to check for null before an instanceof | 453 |
| A method should have only one exit point, and that should be the last statement in the method | 455 |
| Local variable 'metafacade' could be declared final | 457 |
| A method should have only one exit point, and that should be the last statement in the method | 460 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 36 |
| Unnecessary final modifier in final class | 43–46 |
| It is somewhat confusing to have a field name matching the declaring class name | 51 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 51 |
| Unnecessary final modifier in final class | 66–81 |
| Unnecessary final modifier in final class | 90–109 |
| Unnecessary final modifier in final class | 114–117 |
| Violation | Line |
|---|---|
| An Interface should be used only to model a behaviour; consider converting this to a class. | 10–22 |
| Avoid modifiers which are implied by the context | 15 |
| Avoid modifiers which are implied by the context | 21 |
| Avoid excessively long variable names like METAFACADE_IMPLEMENTATION_SUFFIX | 21 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 35 |
| Avoid using redundant field initializer for 'instance' | 40 |
| Singleton is not thread safe | 54–57 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 64 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 69 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 83 |
| Avoid reassigning parameters such as 'metafacadeClass' | 157 |
| Avoid reassigning parameters such as 'metafacadeClass' | 157 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 159 |
| A method should have only one exit point, and that should be the last statement in the method | 170 |
| Avoid if (x != y) ..; else ..; | 193–208 |
| A catch statement should never catch throwable since it includes errors. | 231 |
| A catch statement should never catch throwable since it includes errors. | 288 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 316 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 377 |
| A catch statement should never catch throwable since it includes errors. | 426 |
| Private field 'metafacadeImpls' could be made final; it is only initialized in the declaration or constructor. | 509 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 509 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 514 |
| Use explicit scoping instead of the default package private level | 539–542 |
| Unnecessary final modifier in final class | 539–542 |
| Use explicit scoping instead of the default package private level | 553–581 |
| Unnecessary final modifier in final class | 553–581 |
| Unnecessary final modifier in final class | 591–601 |
| Use explicit scoping instead of the default package private level | 591–601 |
| Local variable 'namespace' could be declared final | 614 |
| Use explicit scoping instead of the default package private level | 631–637 |
| Unnecessary final modifier in final class | 631–637 |
| Avoid if (x != y) ..; else ..; | 652 |
| Use explicit scoping instead of the default package private level | 663–680 |
| Unnecessary final modifier in final class | 663–680 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 686 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 703 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 742 |
| Assigning an Object to null is a code smell. Consider refactoring. | 797 |
| Assigning an Object to null is a code smell. Consider refactoring. | 798 |
| These nested if statements could be combined | 812–819 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Field instance has the same name as a method | 35 |
| Variables that are final and static should be all capitals, 'instance' is not all capitals. | 35 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 40 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 55 |
| Avoid excessively long variable names like METAFACADE_IMPLEMENTATION_SUFFIX | 71 |
| Avoid instantiating new objects inside loops | 99 |
| A catch statement should never catch throwable since it includes errors. | 120 |
| Deeply nested if..then statements are hard to read | 159–194 |
| Avoid empty catch blocks | 173–176 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 173 |
| Use explicit scoping instead of the default package private level | 256 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 256 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 261 |
| Use explicit scoping instead of the default package private level | 261 |
| Use explicit scoping instead of the default package private level | 270–291 |
| A catch statement should never catch throwable since it includes errors. | 286 |
| Use explicit scoping instead of the default package private level | 301–322 |
| Avoid excessively long variable names like metafacadeImplementationClassName | 309 |
| A catch statement should never catch throwable since it includes errors. | 317 |
| Use explicit scoping instead of the default package private level | 327–331 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Avoid using redundant field initializer for 'metafacadeClass' | 29 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 29 |
| A catch statement should never catch throwable since it includes errors. | 52 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 62 |
| Use explicit scoping instead of the default package private level | 85–88 |
| Avoid using redundant field initializer for 'contextRoot' | 107 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 136 |
| Use explicit scoping instead of the default package private level | 153–160 |
| Use explicit scoping instead of the default package private level | 167–170 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 175 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 201 |
| Avoid using redundant field initializer for 'mappingProperties' | 201 |
| Comment is too large: Line too long | 231 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 234 |
| Use explicit scoping instead of the default package private level | 241–244 |
| Use explicit scoping instead of the default package private level | 250–253 |
| Use explicit scoping instead of the default package private level | 261–264 |
| Use explicit scoping instead of the default package private level | 271–274 |
| Use explicit scoping instead of the default package private level | 310–313 |
| Use explicit scoping instead of the default package private level | 320–323 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 328 |
| Use explicit scoping instead of the default package private level | 336–339 |
| Use explicit scoping instead of the default package private level | 346–349 |
| Use explicit scoping instead of the default package private level | 357–369 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 390 |
| Use explicit scoping instead of the default package private level | 397–406 |
| Unnecessary final modifier in final class | 397–406 |
| Unnecessary final modifier in final class | 413–416 |
| Use explicit scoping instead of the default package private level | 413–416 |
| Local variable 'separator' could be declared final | 424 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 447 |
| Private field 'name' could be made final; it is only initialized in the declaration or constructor. | 447 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 448 |
| Private field 'value' could be made final; it is only initialized in the declaration or constructor. | 448 |
| Use explicit scoping instead of the default package private level | 467–470 |
| Unnecessary final modifier in final class | 467–470 |
| Unnecessary final modifier in final class | 477–480 |
| Use explicit scoping instead of the default package private level | 477–480 |
| Violation | Line |
|---|---|
| Avoid really long classes. | 34–1223 |
| The class 'MetafacadeMappings' has a Cyclomatic Complexity of 5 (Highest = 45). | 34–1223 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 43 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 49 |
| Avoid using redundant field initializer for 'defaultMetafacadeClass' | 54 |
| Avoid if (x != y) ..; else ..; | 93–103 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 132 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 159 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 233 |
| Avoid excessively long variable names like METAFACADE_PACKAGE_REPLACE_PATTERN | 238 |
| Local variable 'metafacadeInterfaces' could be declared final | 263 |
| Avoid if (x != y) ..; else ..; | 272–277 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 303 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 320 |
| The method getMapping() has an NPath complexity of 1296555 | 357–542 |
| Avoid really long methods. | 357–542 |
| The method 'getMapping' has a Cyclomatic Complexity of 45. | 357–542 |
| Avoid if (x != y) ..; else ..; | 363 |
| These nested if statements could be combined | 417–432 |
| Deeply nested if..then statements are hard to read | 417–432 |
| Useless parentheses. | 491 |
| Avoid modifiers which are implied by the context | 568–575 |
| Avoid modifiers which are implied by the context | 574 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 611 |
| Local variable 'anInterface' could be declared final | 629 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 643 |
| Local variable 'defaultPropertyReferences' could be declared final | 736 |
| Private field 'parents' could be made final; it is only initialized in the declaration or constructor. | 789 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 789 |
| Use explicit scoping instead of the default package private level | 850–899 |
| Local variable 'namespace1' could be declared final | 854 |
| Avoid instantiating new objects inside loops | 859 |
| Avoid instantiating new objects inside loops | 863 |
| Avoid really long methods. | 941–1045 |
| The method initializeMappings() has an NPath complexity of 255 | 941–1045 |
| Avoid instantiating new objects inside loops | 959 |
| A catch statement should never catch throwable since it includes errors. | 1040 |
| Variables that are final and static should be all capitals, 'allMetafacadeMappingInstances' is not all capitals. | 1050 |
| Use explicit scoping instead of the default package private level | 1058–1061 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 1066 |
| Private field 'metafacadeClasses' could be made final; it is only initialized in the declaration or constructor. | 1066 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 1071 |
| Private field 'modelMetafacadeMappings' could be made final; it is only initialized in the declaration or constructor. | 1071 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 1095 |
| Use explicit scoping instead of the default package private level | 1103–1116 |
| Local variable 'mappings' could be declared final | 1106 |
| A catch statement should never catch throwable since it includes errors. | 1130 |
| Use explicit scoping instead of the default package private level | 1156–1182 |
| These nested if statements could be combined | 1169–1174 |
| Use explicit scoping instead of the default package private level | 1188–1204 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| An Interface should be used only to model a behaviour; consider converting this to a class. | 9–15 |
| Avoid modifiers which are implied by the context | 14 |
| Avoid excessively long variable names like ENABLE_METAFACADE_PROPERTY_CACHING | 14 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 24–330 |
| Use explicit scoping instead of the default package private level | 33–100 |
| A catch statement should never catch throwable since it includes errors. | 81 |
| Use explicit scoping instead of the default package private level | 112–126 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 116 |
| Comment is too large: Line too long | 129 |
| Parameter 'nameSet2' is not assigned and could be declared final | 136 |
| Parameter 'nameSet1' is not assigned and could be declared final | 136 |
| Local variable 'results' could be declared final | 138 |
| A method should have only one exit point, and that should be the last statement in the method | 141 |
| Local variable 'classesToName' could be declared final | 144 |
| Local variable 'classesSet1' could be declared final | 145 |
| Local variable 'classesSet2' could be declared final | 146 |
| Avoid instantiating new objects inside loops | 150 |
| Local variable 'classToCheckInterfaces' could be declared final | 150 |
| Local variable 'expectedResultNotCompliant' could be declared final | 163–170 |
| Avoid instantiating new objects inside loops | 163–170 |
| Parameter 'object' is not assigned and could be declared final | 165 |
| Avoid if (x != y) ..; else ..; | 171–186 |
| Local variable 'expectedResultInterfaces' could be declared final | 174 |
| Avoid instantiating new objects inside loops | 174 |
| Local variable 'classToCheckNotCompliant' could be declared final | 175–182 |
| Avoid instantiating new objects inside loops | 175–182 |
| Parameter 'object' is not assigned and could be declared final | 177 |
| Comment is too large: Line too long | 194 |
| Comment is too large: Line too long | 195 |
| Comment is too large: Line too long | 196 |
| Parameter 'classesToName' is not assigned and could be declared final | 202 |
| Parameter 'nameSet' is not assigned and could be declared final | 202 |
| Avoid variables with short names like cl | 209 |
| Local variable 'cl' could be declared final | 209 |
| Comment is too large: Line too long | 215 |
| Avoid variables with short names like cl | 223 |
| Local variable 'cl' could be declared final | 223 |
| New exception is thrown in catch block, original stack trace may be lost | 229 |
| Avoid throwing raw exception types. | 229 |
| Local variable 'currentInterface' could be declared final | 256 |
| Local variable 'subInheritedMappingClassNames' could be declared final | 258 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 29 |
| Avoid modifiers which are implied by the context | 36 |
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 80 |
| Avoid modifiers which are implied by the context | 89 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 59 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 74 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 89 |
| Avoid using redundant field initializer for 'metafacadeName' | 94 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 94 |
| Deeply nested if..then statements are hard to read | 114–118 |
| Deeply nested if..then statements are hard to read | 119–122 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 134 |
| Avoid using redundant field initializer for 'metafacadeClass' | 134 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 163 |
| Parameter 'object' is not assigned and could be declared final | 181 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 10–54 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 43 |
| Use explicit scoping instead of the default package private level | 72–78 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 83 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 17 |
| Avoid modifiers which are implied by the context | 24 |
| Avoid modifiers which are implied by the context | 33 |
| Avoid modifiers which are implied by the context | 40 |
| Violation | Line |
|---|---|
| Field instance has the same name as a method | 36 |
| Singleton is not thread safe | 45–49 |
| Avoid unnecessary constructors - the compiler will generate these for you | 64–66 |
| Document empty constructor | 64–66 |
| Avoid really long methods. | 71–182 |
| The method discover() has an NPath complexity of 442 | 71–182 |
| Local variable 'requiresMerge' could be declared final | 97 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 144 |
| Deeply nested if..then statements are hard to read | 149–154 |
| Deeply nested if..then statements are hard to read | 159–166 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 211 |
| Private field 'registeredNamespaceResources' could be made final; it is only initialized in the declaration or constructor. | 211 |
| Private field 'registeredRegistries' could be made final; it is only initialized in the declaration or constructor. | 216 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 216 |
| Avoid instantiating new objects inside loops | 241 |
| A catch statement should never catch throwable since it includes errors. | 244 |
| Assigning an Object to null is a code smell. Consider refactoring. | 246 |
| Avoid if (x != y) ..; else ..; | 280–282 |
| Parameter 'path' is not assigned and could be declared final | 309 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 317 |
| Assigning an Object to null is a code smell. Consider refactoring. | 342 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 362 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Parameter 'name' is not assigned and could be declared final | 38 |
| Avoid using redundant field initializer for 'shared' | 46 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 74 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 116 |
| Local variable 'propertyDefinition' could be declared final | 136 |
| Use explicit scoping instead of the default package private level | 148–160 |
| Private field 'resourceRoots' could be made final; it is only initialized in the declaration or constructor. | 190 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 190 |
| Use explicit scoping instead of the default package private level | 208–211 |
| Violation | Line |
|---|---|
| Field instance has the same name as a method | 32 |
| Singleton is not thread safe | 41–44 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 51 |
| Avoid reassigning parameters such as 'name' | 74 |
| Deeply nested if..then statements are hard to read | 93–96 |
| Avoid if (x != y) ..; else ..; | 99 |
| Local variable 'namespace' could be declared final | 110 |
| Avoid if (x != y) ..; else ..; | 133 |
| A catch statement should never catch throwable since it includes errors. | 141 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 150 |
| Avoid if (x != y) ..; else ..; | 158 |
| Assigning an Object to null is a code smell. Consider refactoring. | 214 |
| Violation | Line |
|---|---|
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Parameter 'parent' is not assigned and could be declared final | 49 |
| Violation | Line |
|---|---|
| Field instance has the same name as a method | 29 |
| Singleton is not thread safe | 38–41 |
| It is somewhat confusing to have a field name matching the declaring class name | 48 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 48 |
| Deeply nested if..then statements are hard to read | 70–78 |
| Local variable 'loaded' could be declared final | 149 |
| Avoid if (x != y) ..; else ..; | 153 |
| Local variable 'stream' could be declared final | 188 |
| Violation | Line |
|---|---|
| Avoid using redundant field initializer for 'implementation' | 18 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 18 |
| Violation | Line |
|---|---|
| Parameter 'message' is not assigned and could be declared final | 20 |
| Parameter 'message' is not assigned and could be declared final | 42 |
| Parameter 'cause' is not assigned and could be declared final | 43 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 21 |
| Avoid modifiers which are implied by the context | 26 |
| Avoid modifiers which are implied by the context | 39–41 |
| Comment is too large: Line too long | 45 |
| Avoid modifiers which are implied by the context | 53–56 |
| Avoid modifiers which are implied by the context | 67–71 |
| Avoid modifiers which are implied by the context | 82–85 |
| Avoid modifiers which are implied by the context | 94 |
| Avoid modifiers which are implied by the context | 100 |
| Violation | Line |
|---|---|
| Parameter 'message' is not assigned and could be declared final | 19 |
| Parameter 'message' is not assigned and could be declared final | 41 |
| Parameter 'cause' is not assigned and could be declared final | 42 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 22–23 |
| Avoid modifiers which are implied by the context | 32–33 |
| Violation | Line |
|---|---|
| Parameter 'message' is not assigned and could be declared final | 27 |
| Parameter 'message' is not assigned and could be declared final | 39 |
| Parameter 'parent' is not assigned and could be declared final | 40 |
| Parameter 'parent' is not assigned and could be declared final | 50 |
| Violation | Line |
|---|---|
| New exception is thrown in catch block, original stack trace may be lost | 74 |
| Deeply nested if..then statements are hard to read | 77–84 |
| A catch statement that catches an exception only to rethrow it should be avoided. | 90–95 |
| A catch statement should never catch throwable since it includes errors. | 96 |
| Deeply nested if..then statements are hard to read | 102–112 |
| Avoid empty catch blocks | 108–111 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 31 |
| Avoid using redundant field initializer for 'listener' | 36 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 36 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 41 |
| Private field 'engine' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Deeply nested if..then statements are hard to read | 60–63 |
| New exception is thrown in catch block, original stack trace may be lost | 67–69 |
| Avoid instantiating new objects inside loops | 79 |
| Avoid instantiating new objects inside loops | 81 |
| Deeply nested if..then statements are hard to read | 85–96 |
| A catch statement should never catch throwable since it includes errors. | 98 |
| A catch statement should never catch throwable since it includes errors. | 121 |
| A catch statement should never catch throwable since it includes errors. | 135 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 146 |
| Assigning an Object to null is a code smell. Consider refactoring. | 172 |
| Avoid empty catch blocks | 175–178 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 21 |
| Violation | Line |
|---|---|
| Parameter 'message' is not assigned and could be declared final | 19 |
| Parameter 'message' is not assigned and could be declared final | 31 |
| Parameter 'parent' is not assigned and could be declared final | 32 |
| Parameter 'parent' is not assigned and could be declared final | 42 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 25–26 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 26 |
| Avoid modifiers which are implied by the context | 37–41 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 41 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 85 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 23–25 |
| Violation | Line |
|---|---|
| Avoid instantiating new objects inside loops | 60 |
| Avoid instantiating new objects inside loops | 63 |
| Avoid instantiating new objects inside loops | 65 |
| Avoid instantiating new objects inside loops | 66 |
| Avoid instantiating new objects inside loops | 69 |
| Avoid instantiating new objects inside loops | 75 |
| Deeply nested if..then statements are hard to read | 77–80 |
| Local variable 'outputStream' could be declared final | 81 |
| Avoid instantiating new objects inside loops | 81 |
| Avoid instantiating new objects inside loops | 89 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 100 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 134 |
| Parameter 'location' is not assigned and could be declared final | 141 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 19 |
| Parameter 'message' is not assigned and could be declared final | 29 |
| Parameter 'message' is not assigned and could be declared final | 41 |
| Parameter 'parent' is not assigned and could be declared final | 42 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 17 |
| StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 93 |
| Private field 'originalExpression' could be made final; it is only initialized in the declaration or constructor. | 93 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 19 |
| Variables that are final and static should be all capitals, 'translator' is not all capitals. | 20 |
| Avoid if (x != y) ..; else ..; | 75–83 |
| A catch statement should never catch throwable since it includes errors. | 85 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 14–184 |
| Avoid unnecessary constructors - the compiler will generate these for you | 22–25 |
| Avoid reassigning parameters such as 'string' | 37 |
| Avoid reassigning parameters such as 'string' | 60 |
| Avoid reassigning parameters such as 'property' | 122 |
| Local variable 'dotIndex' could be declared final | 125 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 162 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 22–25 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 28 |
| Private field 'kinds' could be made final; it is only initialized in the declaration or constructor. | 28 |
| Avoid unnecessary constructors - the compiler will generate these for you | 36–39 |
| Avoid reassigning parameters such as 'name' | 77 |
| Local variable 'kind' could be declared final | 82 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 20 |
| Avoid unnecessary constructors - the compiler will generate these for you | 25–28 |
| A catch statement should never catch throwable since it includes errors. | 79 |
| Overriding method merely calls super | 88–91 |
| Violation | Line |
|---|---|
| Parameter 'parent' is not assigned and could be declared final | 16 |
| Parameter 'message' is not assigned and could be declared final | 26 |
| Parameter 'message' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 29 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 39 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 139 |
| Local variable 'handlerMethod' could be declared final | 194 |
| Deeply nested if..then statements are hard to read | 195–234 |
| Local variable 'argTypes' could be declared final | 197 |
| Local variable 'args' could be declared final | 200 |
| Local variable 'errMsg' could be declared final | 212–215 |
| A catch statement should never catch throwable since it includes errors. | 218 |
| Local variable 'trace' could be declared final | 225 |
| Prefer StringBuffer over += for concatenating strings | 229 |
| A catch statement should never catch throwable since it includes errors. | 272 |
| Avoid reassigning parameters such as 'templateContext' | 287 |
| A catch statement should never catch throwable since it includes errors. | 319 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 15–79 |
| Variables that are final and static should be all capitals, 'logger' is not all capitals. | 19 |
| Variables that are final and static should be all capitals, 'libraryTranslations' is not all capitals. | 24 |
| Local variable 'libSeparator' could be declared final | 51 |
| Local variable 'index' could be declared final | 52 |
| Deeply nested if..then statements are hard to read | 69–74 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 20 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 21 |
| Local variable 'nextName' could be declared final | 64 |
| Avoid empty if statements | 75–84 |
| Avoid reassigning parameters such as 'pattern' | 140 |
| Local variable 'nextIgnorePattern' could be declared final | 146 |
| Avoid reassigning parameters such as 'name' | 166 |
| Avoid reassigning parameters such as 'kind' | 167 |
| Local variable 'fragment' could be declared final | 177 |
| Local variable 'begin' could be declared final | 182 |
| Local variable 'beginLength' could be declared final | 183 |
| Local variable 'end' could be declared final | 184 |
| Local variable 'endIndex' could be declared final | 191 |
| Local variable 'toReplace' could be declared final | 198 |
| Avoid instantiating new objects inside loops | 198 |
