The following document contains the results of PMD 5.0.5.
Violation | Line |
---|---|
Avoid using redundant field initializer for 'value' | 15 |
Parameter 'value' is not assigned and could be declared final | 28 |
Local variable 'breadCrumbsObject' could be declared final | 38 |
Local variable 'breadCrumbs' could be declared final | 42 |
Parameter 'breadCrumbs' is not assigned and could be declared final | 54 |
Local variable 'request' could be declared final | 56 |
Local variable 'newCrumb' could be declared final | 58 |
Avoid unnecessary comparisons in boolean expressions | 60 |
Local variable 'lastCrumb' could be declared final | 62 |
Violation | Line |
---|---|
Avoid using redundant field initializer for 'url' | 11 |
Avoid using redundant field initializer for 'value' | 12 |
Parameter 'urlIn' is not assigned and could be declared final | 18 |
Parameter 'valueIn' is not assigned and could be declared final | 18 |
Parameter 'url' is not assigned and could be declared final | 43 |
Avoid using if statements without curly braces | 45–46 |
Parameter 'value' is not assigned and could be declared final | 53 |
Avoid using if statements without curly braces | 55–56 |
Parameter 'breadCrumb' is not assigned and could be declared final | 64 |
Violation | Line |
---|---|
Parameter 'maxSize' is not assigned and could be declared final | 30 |
It is a good practice to call super() in a constructor | 30–33 |
Parameter 'maxSize' is not assigned and could be declared final | 46 |
Parameter 'collection' is not assigned and could be declared final | 54 |
Local variable 'difference' could be declared final | 69 |
Parameter 'element' is not assigned and could be declared final | 77 |
Parameter 'index' is not assigned and could be declared final | 77 |
Parameter 'element' is not assigned and could be declared final | 86 |
Local variable 'added' could be declared final | 88 |
Parameter 'element' is not assigned and could be declared final | 96 |
Parameter 'element' is not assigned and could be declared final | 105 |
Parameter 'collection' is not assigned and could be declared final | 114 |
Parameter 'index' is not assigned and could be declared final | 114 |
Local variable 'added' could be declared final | 116 |
Parameter 'collection' is not assigned and could be declared final | 124 |
Local variable 'added' could be declared final | 126 |
Violation | Line |
---|---|
Avoid using redundant field initializer for 'id' | 14 |
Avoid variables with short names like id | 14 |
Avoid using redundant field initializer for 'toScope' | 15 |
Parameter 'id' is not assigned and could be declared final | 28 |
Avoid variables with short names like id | 28 |
Parameter 'toScope' is not assigned and could be declared final | 44 |
Local variable 'breadCrumbsObject' could be declared final | 54 |
Local variable 'breadCrumbs' could be declared final | 58 |
Deeply nested if..then statements are hard to read | 67–68 |
Avoid using if statements without curly braces | 67–68 |
Avoid using if statements without curly braces | 69–70 |
Deeply nested if..then statements are hard to read | 69–70 |
Avoid using if statements without curly braces | 71–72 |
Deeply nested if..then statements are hard to read | 71–72 |
Deeply nested if..then statements are hard to read | 73–74 |
Avoid using if statements without curly braces | 73–74 |