The following document contains the results of PMD 5.0.5.
Violation | Line |
---|---|
Found non-transient, non-static member. Please mark as transient or provide accessors. | 25 |
Private field 'report' could be made final; it is only initialized in the declaration or constructor. | 30 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 30 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 35 |
Private field 'reportWriter' could be made final; it is only initialized in the declaration or constructor. | 35 |
Avoid using redundant field initializer for 'numberOfErrors' | 60 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 60 |
Parameter 'test' is not assigned and could be declared final | 66 |
Parameter 'throwable' is not assigned and could be declared final | 67 |
Avoid using redundant field initializer for 'numberOfFailures' | 78 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 78 |
Parameter 'test' is not assigned and could be declared final | 84 |
Parameter 'failure' is not assigned and could be declared final | 85 |
Parameter 'test' is not assigned and could be declared final | 96 |
Document empty method | 97–98 |
Avoid using redundant field initializer for 'numberOfTests' | 103 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 103 |
Parameter 'test' is not assigned and could be declared final | 108 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 116 |
Avoid using redundant field initializer for 'startTime' | 116 |
Variables that are final and static should be all capitals, 'newLine' is not all capitals. | 121 |
Parameter 'test' is not assigned and could be declared final | 145 |
Parameter 'throwable' is not assigned and could be declared final | 146 |
Private field 'failures' could be made final; it is only initialized in the declaration or constructor. | 153 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 153 |
Use explicit scoping instead of the default package private level | 161–204 |
Useless parentheses. | 163 |
StringBuffer constructor is initialized with size 16, but has at least 40 characters appended. | 164 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 165 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 166 |
Avoid throwing raw exception types. | 200 |
Use explicit scoping instead of the default package private level | 211–212 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 212 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 213 |
Use explicit scoping instead of the default package private level | 213 |
Violation | Line |
---|---|
Found non-transient, non-static member. Please mark as transient or provide accessors. | 37 |
Comment is too large: Line too long | 40 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 45 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 52 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 61 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 69 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 76 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 81 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 91 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 98 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 107 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 114 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 121 |
Avoid if (x != y) ..; else ..; | 129–196 |
A catch statement should never catch throwable since it includes errors. | 173 |
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 175 |
Violation | Line |
---|---|
Comment is too large: Line too long | 11 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 27 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 34 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 41 |
Found non-transient, non-static member. Please mark as transient or provide accessors. | 48 |
Avoid really long methods. | 52–160 |
The method execute() has an NPath complexity of 600 | 52–160 |
Local variable 'sb' could be declared final | 66 |
Avoid variables with short names like sb | 66 |
The String literal "" appears 17 times in this file; the first occurrence is on line 69 | 69 |
Parameter 'str' is not assigned and could be declared final | 171 |
Parameter 'repeat' is not assigned and could be declared final | 171 |
Local variable 'buffer' could be declared final | 173 |
Avoid variables with short names like sb | 191 |
Parameter 'sb' is not assigned and could be declared final | 191 |
Parameter 'description' is not assigned and could be declared final | 191 |
Parameter 'indent' is not assigned and could be declared final | 191 |
Local variable 'it' could be declared final | 193 |
Parameter 'indentSize' is not assigned and could be declared final | 209 |
Parameter 'indent' is not assigned and could be declared final | 209 |
Parameter 'text' is not assigned and could be declared final | 209 |
Parameter 'lineLength' is not assigned and could be declared final | 209 |
Local variable 'lines' could be declared final | 211 |
Local variable 'ind' could be declared final | 213 |
Local variable 'plainLines' could be declared final | 214 |
Parameter 'line' is not assigned and could be declared final | 231 |
Parameter 'lines' is not assigned and could be declared final | 231 |
Parameter 'indentSize' is not assigned and could be declared final | 231 |
Parameter 'lineLength' is not assigned and could be declared final | 231 |
Local variable 'lineIndent' could be declared final | 233 |
Local variable 'buf' could be declared final | 234 |
Local variable 'tokens' could be declared final | 235 |
Local variable 'token' could be declared final | 238 |
Local variable 'c' could be declared final | 254 |
Avoid variables with short names like c | 254 |
Parameter 'line' is not assigned and could be declared final | 278 |