FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.0
Threshold is
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 31 |
39 |
0 |
0 |
org.andromda.maven.plugin.andromdapp.BeanProperties
| Bug |
Category |
Details |
Line |
Priority |
| org.andromda.maven.plugin.andromdapp.BeanProperties doesn't override java.util.Hashtable.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
org.andromda.maven.plugin.andromdapp.BuildMojo
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.andromda.maven.plugin.andromdapp.BuildMojo.readLine(): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
344 |
High |
| org.andromda.maven.plugin.andromdapp.BuildMojo.execute() forces garbage collection; extremely dubious except in benchmarking code |
PERFORMANCE |
DM_GC |
207 |
High |
| Exception is caught when Exception is not thrown in org.andromda.maven.plugin.andromdapp.BuildMojo.getEnvironment() |
STYLE |
REC_CATCH_EXCEPTION |
273 |
Medium |
| org.andromda.maven.plugin.andromdapp.BuildMojo.collectProjects(String) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
519 |
Medium |
| org.andromda.maven.plugin.andromdapp.BuildMojo.executeModules(String, List, boolean) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
408 |
Medium |
org.andromda.maven.plugin.andromdapp.EclipseMojo
| Bug |
Category |
Details |
Line |
Priority |
| Nullcheck of EclipseMojo.rootProject at line 413 of value previously dereferenced in org.andromda.maven.plugin.andromdapp.EclipseMojo.getRootProject() |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
408 |
Medium |
org.andromda.maven.plugin.andromdapp.JdbcDriverWrapper
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in org.andromda.maven.plugin.andromdapp.JdbcDriverWrapper.getParentLogger() |
STYLE |
REC_CATCH_EXCEPTION |
107 |
Medium |
org.andromda.maven.plugin.andromdapp.SchemaMojo
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.andromda.maven.plugin.andromdapp.SchemaMojo.executeSql(Connection, String): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
490 |
High |
| org.andromda.maven.plugin.andromdapp.SchemaMojo.initializeClassLoaderWithJdbcDriver() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block |
MALICIOUS_CODE |
DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED |
376 |
Medium |
| org.andromda.maven.plugin.andromdapp.SchemaMojo.initializeClasspathFromClassPathElements(Set) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block |
MALICIOUS_CODE |
DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED |
360 |
Medium |
| Null pointer dereference of tasksMap in org.andromda.maven.plugin.andromdapp.SchemaMojo.execute() |
CORRECTNESS |
NP_ALWAYS_NULL |
194 |
Medium |
| Load of known null value in org.andromda.maven.plugin.andromdapp.SchemaMojo.execute() |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
194 |
Medium |
| org.andromda.maven.plugin.andromdapp.SchemaMojo.executeSql(Connection, String) may fail to clean up java.sql.Statement on checked exception |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE |
487 |
Medium |
org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo
| Bug |
Category |
Details |
Line |
Priority |
| org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo.initializeClassLoader(Collection) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block |
MALICIOUS_CODE |
DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED |
198 |
Medium |
org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.getExplodedModuleArtifacts(): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
311 |
High |
| Read of unwritten public or protected field project in org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.execute() |
STYLE |
NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD |
103 |
Medium |
| Read of unwritten public or protected field project in org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.getExplodedModuleArtifacts() |
STYLE |
NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD |
336 |
Medium |
| Read of unwritten public or protected field project in org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.getRootProject() |
STYLE |
NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD |
260 |
Medium |
| org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.getExplodedModuleArtifacts() may fail to clean up java.io.Reader on checked exception |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE |
311 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.execute() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
186 |
Medium |
| Exceptional return value of java.io.File.mkdir() ignored in org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.execute() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
155 |
Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.execute() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
137 |
Medium |
| Unwritten public or protected field: org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.project |
STYLE |
UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD |
103 |
Medium |
org.andromda.maven.plugin.andromdapp.UndeployMojo
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.delete() ignored in org.andromda.maven.plugin.andromdapp.UndeployMojo.execute() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
35 |
Medium |
org.andromda.maven.plugin.andromdapp.eclipse.ClasspathWriter
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.andromda.maven.plugin.andromdapp.eclipse.ClasspathWriter.write(List, String, ArtifactFactory, ArtifactResolver, ArtifactRepository, ArtifactMetadataSource, Set, List, boolean, Variable[], String): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
77 |
High |
org.andromda.maven.plugin.andromdapp.eclipse.ProjectWriter
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.andromda.maven.plugin.andromdapp.eclipse.ProjectWriter.write(): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
38 |
High |
org.andromda.maven.plugin.andromdapp.hibernate.HibernateCreateSchema
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.mkdirs() ignored in org.andromda.maven.plugin.andromdapp.hibernate.HibernateCreateSchema.addArguments(Map, List) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
33 |
Medium |
org.andromda.maven.plugin.andromdapp.hibernate.HibernateDropSchema
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.mkdirs() ignored in org.andromda.maven.plugin.andromdapp.hibernate.HibernateDropSchema.addArguments(Map, List) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
35 |
Medium |
org.andromda.maven.plugin.andromdapp.hibernate.HibernateUpdateSchema
| Bug |
Category |
Details |
Line |
Priority |
| org.andromda.maven.plugin.andromdapp.hibernate.HibernateUpdateSchema.getJdbcDriverJarLoader(Map) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block |
MALICIOUS_CODE |
DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED |
87 |
Medium |
org.andromda.maven.plugin.andromdapp.utils.Projects
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization of static field org.andromda.maven.plugin.andromdapp.utils.Projects.instance in org.andromda.maven.plugin.andromdapp.utils.Projects.instance() |
MT_CORRECTNESS |
LI_LAZY_INIT_STATIC |
27-29 |
Medium |
| Write to static field org.andromda.maven.plugin.andromdapp.utils.Projects.instance from instance method org.andromda.maven.plugin.andromdapp.utils.Projects.clear() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
61 |
High |
