PMD Results

The following document contains the results of PMD 5.0.5.

Files

org/andromda/translation/ocl/query/EjbQLTranslator.java

Violation Line
Do not use the short type 24
Found non-transient, non-static member. Please mark as transient or provide accessors. 24
Private field 'usedArguments' could be made final; it is only initialized in the declaration or constructor. 30
Found non-transient, non-static member. Please mark as transient or provide accessors. 30
Avoid reassigning parameters such as 'replacement' 70
Avoid reassigning parameters such as 'replacement' 70
Parameter 'fragment' is not assigned and could be declared final 70
Parameter 'index' is not assigned and could be declared final 70
Local variable 'usedArgument' could be declared final 76
Avoid reassigning parameters such as 'fragment' 98

org/andromda/translation/ocl/query/QueryTranslator.java

Violation Line
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 28
Found non-transient, non-static member. Please mark as transient or provide accessors. 28
Found non-transient, non-static member. Please mark as transient or provide accessors. 44
Do not use the short type 44
Local variable 'isInitialDeclarator' could be declared final 54
Useless parentheses. 54
Parameter 'declarator' is not assigned and could be declared final 64
Avoid using if statements without curly braces 6768
Local variable 'declaratorName' could be declared final 72
Do not use the short type 75
Parameter 'expression' is not assigned and could be declared final 93
Parameter 'expression' is not assigned and could be declared final 103
Parameter 'logicalExpressionTail' is not assigned and could be declared final 118
Parameter 'relationalExpressionTail' is not assigned and could be declared final 128
Parameter 'expression' is not assigned and could be declared final 138
Parameter 'expression' is not assigned and could be declared final 149
Avoid reassigning parameters such as 'replacement' 164
Avoid reassigning parameters such as 'replacement' 164
Parameter 'index' is not assigned and could be declared final 164
Avoid reassigning parameters such as 'fragment' 164
Avoid reassigning parameters such as 'fragment' 164
Avoid reassigning parameters such as 'replacement' 164
Local variable 'selectClauseTail' could be declared final 197
Local variable 'existingExpression' could be declared final 198
Avoid reassigning parameters such as 'translation' 230
Parameter 'node' is not assigned and could be declared final 230
Local variable 'propertyCallExpression' could be declared final 232
Local variable 'primaryExpression' could be declared final 234
Avoid reassigning parameters such as 'translation' 248
Parameter 'node' is not assigned and could be declared final 248
Avoid reassigning parameters such as 'translation' 248
Local variable 'propertyCallExpression' could be declared final 250
Local variable 'featureCalls' could be declared final 251
Local variable 'params' could be declared final 253
Parameter 'node' is not assigned and could be declared final 269
Parameter 'translation' is not assigned and could be declared final 269
Avoid reassigning parameters such as 'translation' 278
Avoid reassigning parameters such as 'translation' 278
Parameter 'node' is not assigned and could be declared final 278
Local variable 'propertyCallExpression' could be declared final 280
Local variable 'featureCalls' could be declared final 281
Local variable 'parameters' could be declared final 285286
Local variable 'primaryExpression' could be declared final 288
Avoid reassigning parameters such as 'translation' 301
Avoid reassigning parameters such as 'translation' 301
Parameter 'node' is not assigned and could be declared final 301
Local variable 'propertyCallExpression' could be declared final 303
Local variable 'firstArgument' could be declared final 304
Local variable 'featureCalls' could be declared final 306
Local variable 'featureCall' could be declared final 314
Local variable 'parameters' could be declared final 318
Deeply nested if..then statements are hard to read 319326
Local variable 'parameterIterator' could be declared final 321
Found non-transient, non-static member. Please mark as transient or provide accessors. 335
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 335
Parameter 'node' is not assigned and could be declared final 341
Parameter 'translation' is not assigned and could be declared final 341
Parameter 'node' is not assigned and could be declared final 357
Parameter 'translation' is not assigned and could be declared final 357
Avoid reassigning parameters such as 'translation' 369
Avoid reassigning parameters such as 'translation' 369
Parameter 'node' is not assigned and could be declared final 369
Local variable 'relationalExpressionTail' could be declared final 371
Local variable 'leftAndRightExpressions' could be declared final 373374

org/andromda/translation/ocl/query/QueryTranslatorException.java

Violation Line
Avoid variables with short names like th 19
Parameter 'th' is not assigned and could be declared final 19
Parameter 'msg' is not assigned and could be declared final 29
Avoid variables with short names like th 40
Parameter 'msg' is not assigned and could be declared final 40
Parameter 'th' is not assigned and could be declared final 40