PMD Results

The following document contains the results of PMD 5.0.5.

Files

org/andromda/cartridges/java/JavaUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 13–93
Parameter 'packageName' is not assigned and could be declared final 25
Avoid variables with short names like df 30
Parameter 'format' is not assigned and could be declared final 38
Singleton is not thread safe 40–43

org/andromda/cartridges/java/metafacades/JavaClassLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 30
Parameter 'context' is not assigned and could be declared final 31
Parameter 'fault' is not assigned and could be declared final 43
Prefer StringBuffer over += for concatenating strings 51
Local variable 'generalizableElementFacade' could be declared final 133
Use bitwise inversion to invert boolean values 136
Local variable 'parameterIterator' could be declared final 170
Useless parentheses. 173
This statement may have some unnecessary parentheses 173

org/andromda/cartridges/java/metafacades/JavaGlobals.java

Violation Line
Avoid excessively long variable names like INTERFACE_IMPLEMENTATION_NAME_PATTERN 13

org/andromda/cartridges/java/metafacades/JavaClass.java

Violation Line
Avoid modifiers which are implied by the context 22
Avoid modifiers which are implied by the context 28
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 40

org/andromda/cartridges/java/metafacades/JavaClassLogic.java

Violation Line
This class has a bunch of public methods and attributes 5–1395
Abstract classes should be named AbstractXXX 36–1395
Avoid really long classes. 36–1395
Found non-transient, non-static member. Please mark as transient or provide accessors. 44
Parameter 'context' is not assigned and could be declared final 50
Parameter 'metaObjectIn' is not assigned and could be declared final 50
Avoid reassigning parameters such as 'context' 67
Found non-transient, non-static member. Please mark as transient or provide accessors. 76
Private field 'superClassifierFacade' could be made final; it is only initialized in the declaration or constructor. 76
Avoid using redundant field initializer for 'superClassifierFacadeInitialized' 77
Found non-transient, non-static member. Please mark as transient or provide accessors. 77
Avoid excessively long variable names like superClassifierFacadeInitialized 77
Avoid reassigning parameters such as 'context' 98
An empty method in an abstract class should be abstract instead 115–118
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__interfaceImplementationName1a' is not final. 128
Found non-transient, non-static member. Please mark as transient or provide accessors. 128
Avoid excessively long variable names like __interfaceImplementationName1aSet 129
Avoid using redundant field initializer for '__interfaceImplementationName1aSet' 129
Found non-transient, non-static member. Please mark as transient or provide accessors. 129
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__interfaceImplementationName1aSet' is not final. 129
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__fullyQualifiedInterfaceImplementationName2a' is not final. 158
Found non-transient, non-static member. Please mark as transient or provide accessors. 158
Avoid excessively long variable names like __fullyQualifiedInterfaceImplementationName2a 158
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__fullyQualifiedInterfaceImplementationName2aSet' is not final. 159
Found non-transient, non-static member. Please mark as transient or provide accessors. 159
Avoid excessively long variable names like __fullyQualifiedInterfaceImplementationName2aSet 159
Avoid using redundant field initializer for '__fullyQualifiedInterfaceImplementationName2aSet' 159
Avoid excessively long variable names like fullyQualifiedInterfaceImplementationName2a 167
Found non-transient, non-static member. Please mark as transient or provide accessors. 188
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__abstractInterfaceImplementation3a' is not final. 188
Avoid excessively long variable names like __abstractInterfaceImplementation3a 188
Avoid excessively long variable names like __abstractInterfaceImplementation3aSet 189
Avoid using redundant field initializer for '__abstractInterfaceImplementation3aSet' 189
Found non-transient, non-static member. Please mark as transient or provide accessors. 189
Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '__abstractInterfaceImplementation3aSet' is not final. 189
Avoid excessively long variable names like abstractInterfaceImplementation3a 197
An empty method in an abstract class should be abstract instead 216–219
An empty method in an abstract class should be abstract instead 225–228
An empty method in an abstract class should be abstract instead 234–237
Parameter 'name' is not assigned and could be declared final 244
Parameter 'follow' is not assigned and could be declared final 340
Parameter 'follow' is not assigned and could be declared final 437
Parameter 'follow' is not assigned and could be declared final 489
Parameter 'follow' is not assigned and could be declared final 795
Parameter 'tagName' is not assigned and could be declared final 795
Parameter 'element' is not assigned and could be declared final 878
Parameter 'tagName' is not assigned and could be declared final 888
Parameter 'tagName' is not assigned and could be declared final 898
Parameter 'bindedElement' is not assigned and could be declared final 909
Parameter 'kind' is not assigned and could be declared final 928
Parameter 'indent' is not assigned and could be declared final 939
Parameter 'indent' is not assigned and could be declared final 951
Parameter 'lineLength' is not assigned and could be declared final 951
Parameter 'lineLength' is not assigned and could be declared final 962
Parameter 'indent' is not assigned and could be declared final 962
Parameter 'htmlStyle' is not assigned and could be declared final 962
Parameter 'modelName' is not assigned and could be declared final 983
Parameter 'modelName' is not assigned and could be declared final 1080
Parameter 'parameterName' is not assigned and could be declared final 1174
Parameter 'stereotypeName' is not assigned and could be declared final 1203
Parameter 'keywordName' is not assigned and could be declared final 1213
Parameter 'stereotypeName' is not assigned and could be declared final 1230
Parameter 'translation' is not assigned and could be declared final 1299
Parameter 'name' is not assigned and could be declared final 1299
Parameter 'translation' is not assigned and could be declared final 1308
Parameter 'translation' is not assigned and could be declared final 1317
Parameter 'kind' is not assigned and could be declared final 1317
Local variable 'owner' could be declared final 1338
Consider simply returning the value vs storing it in local variable 'owner' 1339
Local variable 'name' could be declared final 1349
Consider simply returning the value vs storing it in local variable 'name' 1350
Parameter 'validationMessages' is not assigned and could be declared final 1358
Avoid appending characters as strings in StringBuffer.append. 1376
A catch statement should never catch throwable since it includes errors. 1381
A catch statement should never catch throwable since it includes errors. 1387
Avoid empty catch blocks 1387–1390
Avoid appending characters as strings in StringBuffer.append. 1392